Skip to content

Commit 7a3b0c8

Browse files
committed
refactor: update blas/ext/base/sapx
update blas/ext/base/sapx to follow current project conventions Fixes: #1152
1 parent 9d915c8 commit 7a3b0c8

File tree

11 files changed

+138
-237
lines changed

11 files changed

+138
-237
lines changed

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/README.md

+10-28
Original file line numberDiff line numberDiff line change
@@ -50,34 +50,30 @@ The function has the following parameters:
5050
- **x**: input [`Float32Array`][@stdlib/array/float32].
5151
- **stride**: index increment.
5252

53-
The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to add a constant to every other element
53+
The `N` and `stride` parameters determine which elements in the strided array are accessed at runtime. For example, to add a constant to every other element
5454

5555
```javascript
5656
var Float32Array = require( '@stdlib/array/float32' );
57-
var floor = require( '@stdlib/math/base/special/floor' );
5857

5958
var x = new Float32Array( [ -2.0, 1.0, 3.0, -5.0, 4.0, 0.0, -1.0, -3.0 ] );
60-
var N = floor( x.length / 2 );
6159

62-
sapx( N, 5.0, x, 2 );
60+
sapx( 4, 5.0, x, 2 );
6361
// x => <Float32Array>[ 3.0, 1.0, 8.0, -5.0, 9.0, 0.0, 4.0, -3.0 ]
6462
```
6563

6664
Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views.
6765

6866
```javascript
6967
var Float32Array = require( '@stdlib/array/float32' );
70-
var floor = require( '@stdlib/math/base/special/floor' );
7168

7269
// Initial array...
7370
var x0 = new Float32Array( [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ] );
7471

7572
// Create an offset view...
7673
var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
77-
var N = floor( x0.length/2 );
7874

7975
// Add a constant to every other element...
80-
sapx( N, 5.0, x1, 2 );
76+
sapx( 3, 5.0, x1, 2 );
8177
// x0 => <Float32Array>[ 1.0, 3.0, 3.0, 1.0, 5.0, -1.0 ]
8278
```
8379

@@ -98,7 +94,7 @@ The function has the following additional parameters:
9894

9995
- **offset**: starting index.
10096

101-
While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to access only the last three elements of `x`
97+
While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to access only the last three elements of the strided array
10298

10399
```javascript
104100
var Float32Array = require( '@stdlib/array/float32' );
@@ -117,7 +113,7 @@ sapx.ndarray( 3, 5.0, x, 1, x.length-3 );
117113

118114
## Notes
119115

120-
- If `N <= 0`, both functions return `x` unchanged.
116+
- If `N <= 0`, both functions return the input array unchanged.
121117

122118
</section>
123119

@@ -130,27 +126,13 @@ sapx.ndarray( 3, 5.0, x, 1, x.length-3 );
130126
<!-- eslint no-undef: "error" -->
131127

132128
```javascript
133-
var round = require( '@stdlib/math/base/special/round' );
134-
var randu = require( '@stdlib/random/base/randu' );
135-
var Float32Array = require( '@stdlib/array/float32' );
129+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
130+
var filledarrayBy = require( '@stdlib/array/filled-by' );
136131
var sapx = require( '@stdlib/blas/ext/base/sapx' );
137132

138-
var rand;
139-
var sign;
140-
var x;
141-
var i;
142-
143-
x = new Float32Array( 10 );
144-
for ( i = 0; i < x.length; i++ ) {
145-
rand = round( randu()*100.0 );
146-
sign = randu();
147-
if ( sign < 0.5 ) {
148-
sign = -1.0;
149-
} else {
150-
sign = 1.0;
151-
}
152-
x[ i ] = sign * rand;
153-
}
133+
var rand = uniform( -100.0, 100.0 );
134+
135+
var x = filledarrayBy( 10, 'float32', rand );
154136
console.log( x );
155137

156138
sapx( x.length, 5.0, x, 1 );

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,19 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
25+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float32Array = require( '@stdlib/array/float32' );
2828
var pkg = require( './../package.json' ).name;
2929
var sapx = require( './../lib/sapx.js' );
3030

3131

32+
// VARIABLES //
33+
34+
var rand = uniform( -100.0, 100.0 );
35+
36+
3237
// FUNCTIONS //
3338

3439
/**
@@ -39,13 +44,7 @@ var sapx = require( './../lib/sapx.js' );
3944
* @returns {Function} benchmark function
4045
*/
4146
function createBenchmark( len ) {
42-
var x;
43-
var i;
44-
45-
x = new Float32Array( len );
46-
for ( i = 0; i < len; i++ ) {
47-
x[ i ] = ( randu()*20.0 ) - 10.0;
48-
}
47+
var x = filledarrayBy( len, 'float32', rand );
4948
return benchmark;
5049

5150
function benchmark( b ) {

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.native.js

+4-9
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float32Array = require( '@stdlib/array/float32' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var pkg = require( './../package.json' ).name;
3131

@@ -36,6 +36,7 @@ var sapx = tryRequire( resolve( __dirname, './../lib/sapx.native.js' ) );
3636
var opts = {
3737
'skip': ( sapx instanceof Error )
3838
};
39+
var rand = uniform( -100.0, 100.0 );
3940

4041

4142
// FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
53-
54-
x = new Float32Array( len );
55-
for ( i = 0; i < len; i++ ) {
56-
x[ i ] = ( randu()*20.0 ) - 10.0;
57-
}
52+
var x = filledarrayBy( len, 'float32', rand );
5853
return benchmark;
5954

6055
function benchmark( b ) {

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.ndarray.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,19 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
25+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float32Array = require( '@stdlib/array/float32' );
2828
var pkg = require( './../package.json' ).name;
2929
var sapx = require( './../lib/ndarray.js' );
3030

3131

32+
// VARIABLES //
33+
34+
var rand = uniform( -100.0, 100.0 );
35+
36+
3237
// FUNCTIONS //
3338

3439
/**
@@ -39,13 +44,7 @@ var sapx = require( './../lib/ndarray.js' );
3944
* @returns {Function} benchmark function
4045
*/
4146
function createBenchmark( len ) {
42-
var x;
43-
var i;
44-
45-
x = new Float32Array( len );
46-
for ( i = 0; i < len; i++ ) {
47-
x[ i ] = ( randu()*20.0 ) - 10.0;
48-
}
47+
var x = filledarrayBy( len, 'float32', rand );
4948
return benchmark;
5049

5150
function benchmark( b ) {

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.ndarray.native.js

+4-9
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' ).factory;
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float32Array = require( '@stdlib/array/float32' );
2929
var tryRequire = require( '@stdlib/utils/try-require' );
3030
var pkg = require( './../package.json' ).name;
3131

@@ -36,6 +36,7 @@ var sapx = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' ) );
3636
var opts = {
3737
'skip': ( sapx instanceof Error )
3838
};
39+
var rand = uniform( -100.0, 100.0 );
3940

4041

4142
// FUNCTIONS //
@@ -48,13 +49,7 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
53-
54-
x = new Float32Array( len );
55-
for ( i = 0; i < len; i++ ) {
56-
x[ i ] = ( randu()*20.0 ) - 10.0;
57-
}
52+
var x = filledarrayBy( len, 'float32', rand );
5853
return benchmark;
5954

6055
function benchmark( b ) {

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/include.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Source files:
3838
'src_files': [
39-
'<(src_dir)/addon.cpp',
39+
'<(src_dir)/addon.c',
4040
'<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).src; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")',
4141
],
4242

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/lib/ndarray.native.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020

2121
// MODULES //
2222

23-
var Float32Array = require( '@stdlib/array/float32' );
23+
var minViewBufferIndex = require( '@stdlib/strided/base/min-view-buffer-index' );
24+
var offsetView = require( '@stdlib/strided/base/offset-view' );
2425
var addon = require( './sapx.native.js' );
2526

2627

@@ -47,10 +48,9 @@ var addon = require( './sapx.native.js' );
4748
*/
4849
function sapx( N, alpha, x, stride, offset ) {
4950
var view;
50-
if ( stride < 0 ) {
51-
offset += (N-1) * stride;
52-
}
53-
view = new Float32Array( x.buffer, x.byteOffset+(x.BYTES_PER_ELEMENT*offset), x.length-offset ); // eslint-disable-line max-len
51+
52+
offset = minViewBufferIndex( N, stride, offset );
53+
view = offsetView( x, offset );
5454
addon( N, alpha, view, stride );
5555
return x;
5656
}
+44-38
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,46 @@
11
{
2-
"options": {},
3-
"fields": [
4-
{
5-
"field": "src",
6-
"resolve": true,
7-
"relative": true
8-
},
9-
{
10-
"field": "include",
11-
"resolve": true,
12-
"relative": true
13-
},
14-
{
15-
"field": "libraries",
16-
"resolve": false,
17-
"relative": false
18-
},
19-
{
20-
"field": "libpath",
21-
"resolve": true,
22-
"relative": false
23-
}
24-
],
25-
"confs": [
26-
{
27-
"src": [
28-
"./src/sapx.c"
29-
],
30-
"include": [
31-
"./include"
32-
],
33-
"libraries": [
34-
"-lm"
35-
],
36-
"libpath": [],
37-
"dependencies": []
38-
}
39-
]
2+
"options": {},
3+
"fields": [
4+
{
5+
"field": "src",
6+
"resolve": true,
7+
"relative": true
8+
},
9+
{
10+
"field": "include",
11+
"resolve": true,
12+
"relative": true
13+
},
14+
{
15+
"field": "libraries",
16+
"resolve": false,
17+
"relative": false
18+
},
19+
{
20+
"field": "libpath",
21+
"resolve": true,
22+
"relative": false
23+
}
24+
],
25+
"confs": [
26+
{
27+
"src": [
28+
"./src/sapx.c"
29+
],
30+
"include": [
31+
"./include"
32+
],
33+
"libraries": [
34+
"-lm"
35+
],
36+
"libpath": [],
37+
"dependencies": [
38+
"@stdlib/napi/export",
39+
"@stdlib/napi/argv",
40+
"@stdlib/napi/argv-int64",
41+
"@stdlib/napi/argv-double",
42+
"@stdlib/napi/argv-strided-float32array"
43+
]
44+
}
45+
]
4046
}

Diff for: lib/node_modules/@stdlib/blas/ext/base/sapx/package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,7 @@
7171
"single",
7272
"float32array"
7373
],
74-
"__stdlib__": {}
74+
"__stdlib__": {
75+
"wasm": false
76+
}
7577
}

0 commit comments

Comments
 (0)