refactor: update blas/ext/base/ssorthp to follow current project conventions
#1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Mar 8, 2024
Pranavchiku
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
This PR needs more changes, please follow d66d80c and add required files.
Pranavchiku
added
the
Needs Changes
stdlib-bot
added
the
BLAS
naveen1m
changed the title
@stdlib/blas/ext/base/ssorthp to follow current project conventions
3 tasks
Planeshifter
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Please have a look at the failing CI job for linting of the C files.
Also, the PR currently took the instruction to "remove the use of floor everywhere" as replacing it via a a right shift operation. This will have to be changed; please consult the linked packages for the changes we are looking for.
Thanks for your efforts!
|
Got it! thanks for the clarification. I will make the necessary changes. |
kgryte
added
Enhancement
6 tasks
naveen1m
changed the title
@stdlib/blas/ext/base/ssorthp to follow current project conventionsblas/ext/base/ssorthp to follow current project conventions
kgryte
reviewed
Apr 7, 2024
lib/node_modules/@stdlib/blas/ext/base/ssorthp/benchmark/benchmark.mostly_sorted_few_uniques.js
Outdated
Show resolved
Hide resolved
…nvention This reverts commit f7b6aa0. Committer: Naveen Kumar <[email protected]>
|
@kgryte @Planeshifter can you please review it? this test is failing, while other file has included same directory see
|
|
Tests should now pass; will merge once CI has passed. Thanks! |
Planeshifter
approved these changes
Apr 27, 2024
Planeshifter
added
Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1537
Description
This pull request:
@stdlib/blas/ext/base/ssorthpto follow current project conventions.Checklist
Related Issues
This pull request:
blas/ext/base/ssorthpto follow current project conventions #1537Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers