Skip to content

refactor: update blas/ext/base/dnanasum to follow current project conventions #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2024
Merged

refactor: update blas/ext/base/dnanasum to follow current project conventions #1924

merged 3 commits into from
Apr 20, 2024

Conversation

raunak-dev-edu
Copy link
Contributor

Resolves #1476 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/dnanasum to follow current project conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 16, 2024
Pranavchiku
Pranavchiku reviewed Mar 17, 2024
View reviewed changes
Pranavchiku
Pranavchiku suggested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, and questions. This PR needs work.

@Pranavchiku Pranavchiku added C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 17, 2024
@raunak-dev-edu
Update manifest.json
cc9a3a3 
Signed-off-by: Raunak Kumar Gupta <[email protected]>
@Planeshifter Planeshifter self-requested a review April 20, 2024 16:58
Planeshifter
Planeshifter approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some minor clean-up. Should be ready to merge now. Thanks @raunak-dev-edu!

@Planeshifter Planeshifter merged commit f0cd892 into stdlib-js:develop Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnanasum to follow current project conventions
4 participants
@raunak-dev-edu @Planeshifter @Pranavchiku @stdlib-bot