Skip to content

refactor: update blas/ext/base/dnannsumkbn2 to follow current project… #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 22, 2024
Merged

refactor: update blas/ext/base/dnannsumkbn2 to follow current project… #2063

merged 36 commits into from
Apr 22, 2024

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Mar 27, 2024

Description

What is the purpose of this pull request?

refactor: update blas/ext/base/dnannsumkbn2 to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2024
@vr-varad vr-varad changed the title refactor: update blas/ext/base/dnannsumkbn2 to follow current project… refactor: update blas/ext/base/dnannsumkbn2 to follow current project… Mar 27, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 28, 2024
@vr-varad
Copy link
Contributor Author

@kgryte @Planeshifter I am getting errors in running tests and constantly getting error:
Running test: lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn2/test/test.dnannsumkbn2.js

29 tests complete (38ms)

Running test: lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn2/test/test.dnannsumkbn2.native.js
/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn2/lib/dnannsumkbn2.native.js:48
addon( N, x, strideX, out, strideOut );
^

RangeError: invalid argument. Fourth argument has insufficient elements based on the associated stride and the number of indexed elements.
at dnannsumkbn2 (/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn2/lib/dnannsumkbn2.native.js:48:2)
at Test.test (/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/blas/ext/base/dnannsumkbn2/test/test.dnannsumkbn2.native.js:59:6)
at Test.bound [as _cb] (/home/runner/work/stdlib/stdlib/node_modules/tape/lib/test.js:58:32)
at Test.run (/home/runner/work/stdlib/stdlib/node_modules/tape/lib/test.js:77:10)
at Test.bound [as run] (/home/runner/work/stdlib/stdlib/node_modules/tape/lib/test.js:58:32)
at Immediate.next (/home/runner/work/stdlib/stdlib/node_modules/tape/lib/results.js:70:15)
at processImmediate (node:internal/timers:466:21)

can u help me with this?

@vr-varad
Copy link
Contributor Author

@kgryte @Planeshifter I'm delighted to inform you that I've successfully resolved the error we encountered earlier. I want to extend my heartfelt gratitude to @kgryte for your invaluable guidance throughout this process.

I'm now ready to proceed with the review. Thank you once again for your assistance.

@Planeshifter Planeshifter self-requested a review April 21, 2024 21:10
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vr-varad!

@Planeshifter Planeshifter merged commit 0f07a02 into stdlib-js:develop Apr 22, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnannsumkbn2 to follow current project conventions
4 participants