-
-
Notifications
You must be signed in to change notification settings - Fork 834
feat: add C implementation of stats/base/dists/arcsine/logpdf
#3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @MeastroZI. Looks like you are missing changes to the package README.
...les/@stdlib/stats/base/dists/arcsine/logpdf/include/stdlib/stats/base/dists/arcsine/logpdf.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/src/main.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/arcsine/logpdf/examples/c/example.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
stats/base/dists/arcsine/logpdf
stats/base/dists/arcsine/logpdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @MeastroZI!
Fixed a few small things (in example printouts:F
is used for the CDF, whereas f
should be used for the PDF) but the PR looks good to me overall and should be ready to land! 🚀
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
Resolves #3401
Description
This pull request:
stats/base/dists/arcsine/logpdf
Related Issues
This pull request:
@stdlib/stats/base/dists/arcsine/logpdf
#3401Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers