From 0ef9ab62bfe719aea5f5fcacdf29b9507aa3da24 Mon Sep 17 00:00:00 2001 From: gururaj1512 Date: Mon, 2 Jun 2025 13:11:56 +0000 Subject: [PATCH 1/5] feat: add support for accessor arrays and refactor `stats/base/nanmaxabs` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- .../@stdlib/stats/base/nanmaxabs/README.md | 59 +++---- .../base/nanmaxabs/benchmark/benchmark.js | 31 ++-- .../nanmaxabs/benchmark/benchmark.ndarray.js | 29 ++-- .../stats/base/nanmaxabs/docs/repl.txt | 32 ++-- .../base/nanmaxabs/docs/types/index.d.ts | 19 ++- .../stats/base/nanmaxabs/docs/types/test.ts | 3 + .../stats/base/nanmaxabs/examples/index.js | 21 +-- .../lib/{nanmaxabs.js => accessors.js} | 51 +++--- .../@stdlib/stats/base/nanmaxabs/lib/index.js | 14 +- .../@stdlib/stats/base/nanmaxabs/lib/main.js | 21 ++- .../stats/base/nanmaxabs/lib/ndarray.js | 28 ++-- .../base/nanmaxabs/test/test.nanmaxabs.js | 155 ++++++++++++++++-- .../stats/base/nanmaxabs/test/test.ndarray.js | 148 +++++++++++++++-- 13 files changed, 451 insertions(+), 160 deletions(-) rename lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/{nanmaxabs.js => accessors.js} (56%) diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/README.md b/lib/node_modules/@stdlib/stats/base/nanmaxabs/README.md index a13176260aa9..edb8529db0e0 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/README.md +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/README.md @@ -36,15 +36,14 @@ limitations under the License. var nanmaxabs = require( '@stdlib/stats/base/nanmaxabs' ); ``` -#### nanmaxabs( N, x, stride ) +#### nanmaxabs( N, x, strideX ) -Computes the maximum absolute value of a strided array `x`, ignoring `NaN` values. +Computes the maximum absolute value of a strided array, ignoring `NaN` values. ```javascript var x = [ 1.0, -2.0, NaN, 2.0 ]; -var N = x.length; -var v = nanmaxabs( N, x, 1 ); +var v = nanmaxabs( x.length, x, 1 ); // returns 2.0 ``` @@ -52,17 +51,14 @@ The function has the following parameters: - **N**: number of indexed elements. - **x**: input [`Array`][mdn-array] or [`typed array`][mdn-typed-array]. -- **stride**: index increment for `x`. +- **strideX**: stride length for `x`. -The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the maximum absolute value of every other element in `x`, +The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the maximum absolute value of every other element in `x`, ```javascript -var floor = require( '@stdlib/math/base/special/floor' ); - var x = [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0, NaN, NaN ]; -var N = floor( x.length / 2 ); -var v = nanmaxabs( N, x, 2 ); +var v = nanmaxabs( 5, x, 2 ); // returns 4.0 ``` @@ -72,42 +68,35 @@ Note that indexing is relative to the first index. To introduce an offset, use [ ```javascript var Float64Array = require( '@stdlib/array/float64' ); -var floor = require( '@stdlib/math/base/special/floor' ); var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, NaN, NaN, 4.0 ] ); var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element -var N = floor( x0.length / 2 ); - -var v = nanmaxabs( N, x1, 2 ); +var v = nanmaxabs( 4, x1, 2 ); // returns 4.0 ``` -#### nanmaxabs.ndarray( N, x, stride, offset ) +#### nanmaxabs.ndarray( N, x, strideX, offsetX ) Computes the maximum absolute value of a strided array, ignoring `NaN` values and using alternative indexing semantics. ```javascript var x = [ 1.0, -2.0, NaN, 2.0 ]; -var N = x.length; -var v = nanmaxabs.ndarray( N, x, 1, 0 ); +var v = nanmaxabs.ndarray( x.length, x, 1, 0 ); // returns 2.0 ``` The function has the following additional parameters: -- **offset**: starting index for `x`. +- **offsetX**: starting index for `x`. -While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other value in `x` starting from the second value +While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the maximum absolute value for every other element in `x` starting from the second element ```javascript -var floor = require( '@stdlib/math/base/special/floor' ); - var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, NaN, NaN, 2.0, 3.0, 4.0 ]; -var N = floor( x.length / 2 ); -var v = nanmaxabs.ndarray( N, x, 2, 1 ); +var v = nanmaxabs.ndarray( 5, x, 2, 1 ); // returns 4.0 ``` @@ -120,6 +109,7 @@ var v = nanmaxabs.ndarray( N, x, 2, 1 ); ## Notes - If `N <= 0`, both functions return `NaN`. +- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]). - Depending on the environment, the typed versions ([`dnanmaxabs`][@stdlib/stats/strided/dnanmaxabs], [`snanmaxabs`][@stdlib/stats/strided/snanmaxabs], etc.) are likely to be significantly more performant. @@ -133,22 +123,19 @@ var v = nanmaxabs.ndarray( N, x, 2, 1 ); ```javascript -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var nanmaxabs = require( '@stdlib/stats/base/nanmaxabs' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( (randu()*100.0) - 50.0 ); +function rand() { + if ( bernoulli( 0.8 ) < 1 ) { + return NaN; } + return uniform( -50.0, 50.0 ); } + +var x = filledarrayBy( 10, 'float64', rand ); console.log( x ); var v = nanmaxabs( x.length, x, 1 ); @@ -185,6 +172,8 @@ console.log( v ); [mdn-typed-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray +[@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor + [@stdlib/stats/strided/dnanmaxabs]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/dnanmaxabs diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.js index 68077cc5f91b..e532cf79c886 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.js @@ -21,15 +21,30 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); var pow = require( '@stdlib/math/base/special/pow' ); var pkg = require( './../package.json' ).name; -var nanmaxabs = require( './../lib/nanmaxabs.js' ); +var nanmaxabs = require( './../lib/main.js' ); // FUNCTIONS // +/** +* Returns a random number. +* +* @private +* @returns {number} random number +*/ +function rand() { + if ( bernoulli( 0.8 ) < 1 ) { + return NaN; + } + return uniform( -10.0, 10.0 ); +} + /** * Creates a benchmark function. * @@ -38,17 +53,7 @@ var nanmaxabs = require( './../lib/nanmaxabs.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = []; - for ( i = 0; i < len; i++ ) { - if ( randu() < 0.2 ) { - x.push( NaN ); - } else { - x.push( ( randu()*20.0 ) - 10.0 ); - } - } + var x = filledarrayBy( len, 'generic', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.ndarray.js index 3927f9a2e182..9284e0468efa 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/benchmark/benchmark.ndarray.js @@ -21,8 +21,10 @@ // MODULES // var bench = require( '@stdlib/bench' ); -var randu = require( '@stdlib/random/base/randu' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); var pow = require( '@stdlib/math/base/special/pow' ); var pkg = require( './../package.json' ).name; var nanmaxabs = require( './../lib/ndarray.js' ); @@ -30,6 +32,19 @@ var nanmaxabs = require( './../lib/ndarray.js' ); // FUNCTIONS // +/** +* Returns a random number. +* +* @private +* @returns {number} random number +*/ +function rand() { + if ( bernoulli( 0.8 ) < 1 ) { + return NaN; + } + return uniform( -10.0, 10.0 ); +} + /** * Creates a benchmark function. * @@ -38,17 +53,7 @@ var nanmaxabs = require( './../lib/ndarray.js' ); * @returns {Function} benchmark function */ function createBenchmark( len ) { - var x; - var i; - - x = []; - for ( i = 0; i < len; i++ ) { - if ( randu() < 0.2 ) { - x.push( NaN ); - } else { - x.push( ( randu()*20.0 ) - 10.0 ); - } - } + var x = filledarrayBy( len, 'generic', rand ); return benchmark; function benchmark( b ) { diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/repl.txt b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/repl.txt index f605750df30e..8969c373d42e 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/repl.txt +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/repl.txt @@ -1,10 +1,10 @@ -{{alias}}( N, x, stride ) +{{alias}}( N, x, strideX ) Computes the maximum absolute value of a strided array, ignoring `NaN` values. - The `N` and `stride` parameters determine which elements in `x` are accessed - at runtime. + The `N` and stride parameters determine which elements in the strided array + are accessed at runtime. Indexing is relative to the first index. To introduce an offset, use a typed array view. @@ -19,8 +19,8 @@ x: Array|TypedArray Input array. - stride: integer - Index increment. + strideX: integer + Stride length. Returns ------- @@ -34,22 +34,19 @@ > {{alias}}( x.length, x, 1 ) 2.0 - // Using `N` and `stride` parameters: + // Using `N` and stride parameters: > x = [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0, NaN, NaN ]; - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > var stride = 2; - > {{alias}}( N, x, stride ) + > {{alias}}( 4, x, 2 ) 2.0 // Using view offsets: > var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ] ); > var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); - > N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 ); - > stride = 2; - > {{alias}}( N, x1, stride ) + > {{alias}}( 4, x1, 2 ) 2.0 -{{alias}}.ndarray( N, x, stride, offset ) + +{{alias}}.ndarray( N, x, strideX, offsetX ) Computes the maximum absolute value of a strided array, ignoring `NaN` values and using alternative indexing semantics. @@ -65,10 +62,10 @@ x: Array|TypedArray Input array. - stride: integer - Index increment. + strideX: integer + Stride length. - offset: integer + offsetX: integer Starting index. Returns @@ -85,8 +82,7 @@ // Using offset parameter: > var x = [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ]; - > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 ); - > {{alias}}.ndarray( N, x, 2, 1 ) + > {{alias}}.ndarray( 4, x, 2, 1 ) 2.0 See Also diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/index.d.ts b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/index.d.ts index 33687f14025b..1cfd2fb2733f 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/index.d.ts +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/index.d.ts @@ -20,7 +20,12 @@ /// -import { NumericArray } from '@stdlib/types/array'; +import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array'; + +/** +* Input array. +*/ +type InputArray = NumericArray | Collection | AccessorArrayLike; /** * Interface describing `nanmaxabs`. @@ -31,7 +36,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length + * @param strideX - stride length * @returns maximum absolute value * * @example @@ -40,15 +45,15 @@ interface Routine { * var v = nanmaxabs( x.length, x, 1 ); * // returns 2.0 */ - ( N: number, x: NumericArray, stride: number ): number; + ( N: number, x: InputArray, strideX: number ): number; /** * Computes the maximum absolute value of a strided array, ignoring `NaN` values and using alternative indexing semantics. * * @param N - number of indexed elements * @param x - input array - * @param stride - stride length - * @param offset - starting index + * @param strideX - stride length + * @param offsetX - starting index * @returns maximum absolute value * * @example @@ -57,7 +62,7 @@ interface Routine { * var v = nanmaxabs.ndarray( x.length, x, 1, 0 ); * // returns 2.0 */ - ndarray( N: number, x: NumericArray, stride: number, offset: number ): number; + ndarray( N: number, x: InputArray, strideX: number, offsetX: number ): number; } /** @@ -65,7 +70,7 @@ interface Routine { * * @param N - number of indexed elements * @param x - input array -* @param stride - stride length +* @param strideX - stride length * @returns maximum absolute value * * @example diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/test.ts b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/test.ts index bf70b119e0f9..68941d741ed2 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/test.ts +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/docs/types/test.ts @@ -16,6 +16,7 @@ * limitations under the License. */ +import AccessorArray = require( '@stdlib/array/base/accessor' ); import nanmaxabs = require( './index' ); @@ -26,6 +27,7 @@ import nanmaxabs = require( './index' ); const x = new Float64Array( 10 ); nanmaxabs( x.length, x, 1 ); // $ExpectType number + nanmaxabs( x.length, new AccessorArray( x ), 1 ); // $ExpectType number } // The compiler throws an error if the function is provided a first argument which is not a number... @@ -85,6 +87,7 @@ import nanmaxabs = require( './index' ); const x = new Float64Array( 10 ); nanmaxabs.ndarray( x.length, x, 1, 0 ); // $ExpectType number + nanmaxabs.ndarray( x.length, new AccessorArray( x ), 1, 0 ); // $ExpectType number } // The compiler throws an error if the `ndarray` method is provided a first argument which is not a number... diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/examples/index.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/examples/index.js index 803a2025e406..98be17c49a45 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/examples/index.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/examples/index.js @@ -18,22 +18,19 @@ 'use strict'; -var randu = require( '@stdlib/random/base/randu' ); -var round = require( '@stdlib/math/base/special/round' ); -var Float64Array = require( '@stdlib/array/float64' ); +var uniform = require( '@stdlib/random/base/uniform' ); +var filledarrayBy = require( '@stdlib/array/filled-by' ); +var bernoulli = require( '@stdlib/random/base/bernoulli' ); var nanmaxabs = require( './../lib' ); -var x; -var i; - -x = new Float64Array( 10 ); -for ( i = 0; i < x.length; i++ ) { - if ( randu() < 0.2 ) { - x[ i ] = NaN; - } else { - x[ i ] = round( (randu()*100.0) - 50.0 ); +function rand() { + if ( bernoulli( 0.8 ) < 1 ) { + return NaN; } + return uniform( -50.0, 50.0 ); } + +var x = filledarrayBy( 10, 'float64', rand ); console.log( x ); var v = nanmaxabs( x.length, x, 1 ); diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/nanmaxabs.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js similarity index 56% rename from lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/nanmaxabs.js rename to lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js index b3fddc634530..76f9f6260e3a 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/nanmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js @@ -1,7 +1,7 @@ /** * @license Apache-2.0 * -* Copyright (c) 2020 The Stdlib Authors. +* Copyright (c) 2025 The Stdlib Authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -29,41 +29,48 @@ var abs = require( '@stdlib/math/base/special/abs' ); /** * Computes the maximum absolute value of a strided array, ignoring `NaN` values. * +* @private * @param {PositiveInteger} N - number of indexed elements -* @param {NumericArray} x - input array -* @param {integer} stride - stride length +* @param {Object} x - input array object +* @param {Collection} x.data - input array data +* @param {Array} x.accessors - array element accessors +* @param {integer} strideX - stride length +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} maximum absolute value * * @example -* var x = [ 1.0, -2.0, NaN, 2.0 ]; -* var N = x.length; +* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); +* var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); * -* var v = nanmaxabs( N, x, 1 ); -* // returns 2.0 +* var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ] ); +* +* var v = nanmaxabs( 5, arraylike2object( x ), 2, 1 ); +* // returns 4.0 */ -function nanmaxabs( N, x, stride ) { +function nanmaxabs( N, x, strideX, offsetX ) { + var xbuf; + var get; var max; var ix; var v; var i; - if ( N <= 0 ) { - return NaN; - } - if ( N === 1 || stride === 0 ) { - return x[ 0 ]; - } - if ( stride < 0 ) { - ix = (1-N) * stride; - } else { - ix = 0; + // Cache reference to array data: + xbuf = x.data; + + // Cache a reference to the element accessor: + get = x.accessors[ 0 ]; + + if ( N === 1 || strideX === 0 ) { + return get( xbuf, offsetX ); } + ix = offsetX; for ( i = 0; i < N; i++ ) { - v = x[ ix ]; + v = get( xbuf, ix ); if ( v === v ) { break; } - ix += stride; + ix += strideX; } if ( i === N ) { return NaN; @@ -71,8 +78,8 @@ function nanmaxabs( N, x, stride ) { max = abs( v ); i += 1; for ( i; i < N; i++ ) { - ix += stride; - v = abs( x[ ix ] ); + ix += strideX; + v = abs( get( xbuf, ix ) ); if ( isnan( v ) ) { continue; } diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/index.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/index.js index 0340403b00ee..1813e0ecc351 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/index.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/index.js @@ -27,25 +27,29 @@ * var nanmaxabs = require( '@stdlib/stats/base/nanmaxabs' ); * * var x = [ 1.0, -2.0, NaN, 2.0 ]; -* var N = x.length; * -* var v = nanmaxabs( N, x, 1 ); +* var v = nanmaxabs( x.length, x, 1 ); * // returns 2.0 * * @example -* var floor = require( '@stdlib/math/base/special/floor' ); * var nanmaxabs = require( '@stdlib/stats/base/nanmaxabs' ); * * var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ]; -* var N = floor( x.length / 2 ); * -* var v = nanmaxabs.ndarray( N, x, 2, 1 ); +* var v = nanmaxabs.ndarray( 5, x, 2, 1 ); * // returns 4.0 */ // MODULES // +var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-property' ); var main = require( './main.js' ); +var ndarray = require( './ndarray.js' ); + + +// MAIN // + +setReadOnly( main, 'ndarray', ndarray ); // EXPORTS // diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/main.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/main.js index 755f56ec1123..597310924029 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/main.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/main.js @@ -20,14 +20,29 @@ // MODULES // -var setReadOnly = require( '@stdlib/utils/define-nonenumerable-read-only-property' ); -var nanmaxabs = require( './nanmaxabs.js' ); +var stride2offset = require( '@stdlib/strided/base/stride2offset' ); var ndarray = require( './ndarray.js' ); // MAIN // -setReadOnly( nanmaxabs, 'ndarray', ndarray ); +/** +* Computes the maximum absolute value of a strided array, ignoring `NaN` values. +* +* @param {PositiveInteger} N - number of indexed elements +* @param {NumericArray} x - input array +* @param {integer} strideX - stride length +* @returns {number} maximum absolute value +* +* @example +* var x = [ 1.0, -2.0, NaN, 2.0 ]; +* +* var v = nanmaxabs( x.length, x, 1 ); +* // returns 2.0 +*/ +function nanmaxabs( N, x, strideX ) { + return ndarray( N, x, strideX, stride2offset( N, strideX ) ); +} // EXPORTS // diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js index cc144dd7f0f8..ebbb52164dac 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js @@ -22,6 +22,8 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' ); var abs = require( '@stdlib/math/base/special/abs' ); +var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); +var accessors = require( './accessors.js' ); // MAIN // @@ -31,38 +33,40 @@ var abs = require( '@stdlib/math/base/special/abs' ); * * @param {PositiveInteger} N - number of indexed elements * @param {NumericArray} x - input array -* @param {integer} stride - stride length -* @param {NonNegativeInteger} offset - starting index +* @param {integer} strideX - stride length +* @param {NonNegativeInteger} offsetX - starting index * @returns {number} maximum absolute value * * @example -* var floor = require( '@stdlib/math/base/special/floor' ); -* * var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ]; -* var N = floor( x.length / 2 ); * -* var v = nanmaxabs( N, x, 2, 1 ); +* var v = nanmaxabs( 5, x, 2, 1 ); * // returns 4.0 */ -function nanmaxabs( N, x, stride, offset ) { +function nanmaxabs( N, x, strideX, offsetX ) { var max; var ix; + var o; var v; var i; if ( N <= 0 ) { return NaN; } - if ( N === 1 || stride === 0 ) { - return x[ offset ]; + o = arraylike2object( x ); + if ( o.accessorProtocol ) { + return accessors( N, o, strideX, offsetX ); + } + if ( N === 1 || strideX === 0 ) { + return x[ offsetX ]; } - ix = offset; + ix = offsetX; for ( i = 0; i < N; i++ ) { v = x[ ix ]; if ( v === v ) { break; } - ix += stride; + ix += strideX; } if ( i === N ) { return NaN; @@ -70,7 +74,7 @@ function nanmaxabs( N, x, stride, offset ) { max = abs( v ); i += 1; for ( i; i < N; i++ ) { - ix += stride; + ix += strideX; v = abs( x[ ix ] ); if ( isnan( v ) ) { continue; diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js index 6b01fb9969a5..ec72149c2fc7 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js @@ -21,11 +21,11 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var Float64Array = require( '@stdlib/array/float64' ); -var nanmaxabs = require( './../lib/nanmaxabs.js' ); +var nanmaxabs = require( './../lib/main.js' ); // TESTS // @@ -68,6 +68,33 @@ tape( 'the function calculates the maximum absolute value of a strided array', f t.end(); }); +tape( 'the function calculates the maximum absolute value of a strided array (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 0.0, 3.0, NaN, NaN ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1 ); + t.strictEqual( v, 5.0, 'returns expected value' ); + + x = [ -4.0, NaN, -5.0 ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1 ); + t.strictEqual( v, 5.0, 'returns expected value' ); + + x = [ -0.0, NaN, 0.0, -0.0 ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1 ); + t.strictEqual( isPositiveZero( v ), true, 'returns expected value' ); + + x = [ NaN ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + x = [ NaN, NaN ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + t.end(); +}); + tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `NaN`', function test( t ) { var x; var v; @@ -83,6 +110,21 @@ tape( 'if provided an `N` parameter less than or equal to `0`, the function retu t.end(); }); +tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `NaN` (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( 0, toAccessorArray( x ), 1 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + v = nanmaxabs( -1, toAccessorArray( x ), 1 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + t.end(); +}); + tape( 'if provided an `N` parameter equal to `1`, the function returns the first element', function test( t ) { var x; var v; @@ -95,8 +137,19 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first t.end(); }); +tape( 'if provided an `N` parameter equal to `1`, the function returns the first element (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( 1, toAccessorArray( x ), 1 ); + t.strictEqual( v, 1.0, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -113,15 +166,36 @@ tape( 'the function supports a `stride` parameter', function test( t ) { NaN ]; - N = floor( x.length / 2 ); - v = nanmaxabs( N, x, 2 ); + v = nanmaxabs( 5, x, 2 ); + + t.strictEqual( v, 4.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a `stride` parameter (accessors)', function test( t ) { + var x; + var v; + + x = [ + 1.0, // 0 + 2.0, + 2.0, // 1 + -7.0, + -2.0, // 2 + 3.0, + 4.0, // 3 + 2.0, + NaN, // 4 + NaN + ]; + + v = nanmaxabs( 5, toAccessorArray( x ), 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -138,8 +212,30 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]; - N = floor( x.length / 2 ); - v = nanmaxabs( N, x, -2 ); + v = nanmaxabs( 5, x, -2 ); + + t.strictEqual( v, 4.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a negative `stride` parameter (accessors)', function test( t ) { + var x; + var v; + + x = [ + NaN, // 4 + NaN, + 1.0, // 3 + 2.0, + 2.0, // 2 + -7.0, + -2.0, // 1 + 3.0, + 4.0, // 0 + 2.0 + ]; + + v = nanmaxabs( 5, toAccessorArray( x ), -2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -157,10 +253,21 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f t.end(); }); +tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( x.length, toAccessorArray( x ), 0 ); + t.strictEqual( v, 1.0, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports view offsets', function test( t ) { var x0; var x1; - var N; var v; x0 = new Float64Array([ @@ -178,9 +285,35 @@ tape( 'the function supports view offsets', function test( t ) { ]); x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element - N = floor(x1.length / 2); - v = nanmaxabs( N, x1, 2 ); + v = nanmaxabs( 5, x1, 2 ); + t.strictEqual( v, 4.0, 'returns expected value' ); + + t.end(); +}); + +tape( 'the function supports view offsets (accessors)', function test( t ) { + var x0; + var x1; + var v; + + x0 = new Float64Array([ + 2.0, + 1.0, // 0 + 2.0, + -2.0, // 1 + -2.0, + 2.0, // 2 + 3.0, + 4.0, // 3 + 6.0, + NaN, // 4 + NaN + ]); + + x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element + + v = nanmaxabs( 5, toAccessorArray( x1 ), 2 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js index 97b50d1c6c2b..f1054fa915c9 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js @@ -21,9 +21,9 @@ // MODULES // var tape = require( 'tape' ); -var floor = require( '@stdlib/math/base/special/floor' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' ); +var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); var nanmaxabs = require( './../lib/ndarray.js' ); @@ -67,6 +67,33 @@ tape( 'the function calculates the maximum absolute value of a strided array', f t.end(); }); +tape( 'the function calculates the maximum absolute value of a strided array (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, NaN, 0.0, 3.0 ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1, 0 ); + t.strictEqual( v, 5.0, 'returns expected value' ); + + x = [ -4.0, NaN, -5.0 ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1, 0 ); + t.strictEqual( v, 5.0, 'returns expected value' ); + + x = [ -0.0, 0.0, NaN, -0.0 ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1, 0 ); + t.strictEqual( isPositiveZero( v ), true, 'returns expected value' ); + + x = [ NaN ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1, 0 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + x = [ NaN, NaN ]; + v = nanmaxabs( x.length, toAccessorArray( x ), 1, 0 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + t.end(); +}); + tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `NaN`', function test( t ) { var x; var v; @@ -82,6 +109,21 @@ tape( 'if provided an `N` parameter less than or equal to `0`, the function retu t.end(); }); +tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `NaN` (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( 0, toAccessorArray( x ), 1, 0 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + v = nanmaxabs( -1, toAccessorArray( x ), 1, 0 ); + t.strictEqual( isnan( v ), true, 'returns expected value' ); + + t.end(); +}); + tape( 'if provided an `N` parameter equal to `1`, the function returns the first indexed element', function test( t ) { var x; var v; @@ -94,8 +136,19 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first t.end(); }); +tape( 'if provided an `N` parameter equal to `1`, the function returns the first indexed element (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( 1, toAccessorArray( x ), 1, 0 ); + t.strictEqual( v, 1.0, 'returns expected value' ); + + t.end(); +}); + tape( 'the function supports a `stride` parameter', function test( t ) { - var N; var x; var v; @@ -112,15 +165,36 @@ tape( 'the function supports a `stride` parameter', function test( t ) { NaN ]; - N = floor( x.length / 2 ); - v = nanmaxabs( N, x, 2, 0 ); + v = nanmaxabs( 5, x, 2, 0 ); + + t.strictEqual( v, 4.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a `stride` parameter (accessors)', function test( t ) { + var x; + var v; + + x = [ + 1.0, // 0 + 2.0, + 2.0, // 1 + -7.0, + -2.0, // 2 + 3.0, + 4.0, // 3 + 2.0, + NaN, // 4 + NaN + ]; + + v = nanmaxabs( 5, toAccessorArray( x ), 2, 0 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); }); tape( 'the function supports a negative `stride` parameter', function test( t ) { - var N; var x; var v; @@ -137,8 +211,30 @@ tape( 'the function supports a negative `stride` parameter', function test( t ) 2.0 ]; - N = floor( x.length / 2 ); - v = nanmaxabs( N, x, -2, 8 ); + v = nanmaxabs( 5, x, -2, 8 ); + + t.strictEqual( v, 4.0, 'returns expected value' ); + t.end(); +}); + +tape( 'the function supports a negative `stride` parameter (accessors)', function test( t ) { + var x; + var v; + + x = [ + NaN, // 4 + NaN, + 1.0, // 3 + 2.0, + 2.0, // 2 + -7.0, + -2.0, // 1 + 3.0, + 4.0, // 0 + 2.0 + ]; + + v = nanmaxabs( 5, toAccessorArray( x ), -2, 8 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); @@ -155,9 +251,19 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f t.end(); }); +tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element (accessors)', function test( t ) { + var x; + var v; + + x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + + v = nanmaxabs( x.length, toAccessorArray( x ), 0, 0 ); + t.strictEqual( v, 1.0, 'returns expected value' ); + + t.end(); +}); tape( 'the function supports an `offset` parameter', function test( t ) { - var N; var x; var v; @@ -173,9 +279,31 @@ tape( 'the function supports an `offset` parameter', function test( t ) { NaN, NaN // 4 ]; - N = floor( x.length / 2 ); - v = nanmaxabs( N, x, 2, 1 ); + v = nanmaxabs( 5, x, 2, 1 ); + t.strictEqual( v, 4.0, 'returns expected value' ); + + t.end(); +}); + +tape( 'the function supports an `offset` parameter (accessors)', function test( t ) { + var x; + var v; + + x = [ + 2.0, + 1.0, // 0 + 2.0, + -2.0, // 1 + -2.0, + 2.0, // 2 + 3.0, + 4.0, // 3 + NaN, + NaN // 4 + ]; + + v = nanmaxabs( 5, toAccessorArray( x ), 2, 1 ); t.strictEqual( v, 4.0, 'returns expected value' ); t.end(); From c9d9fae16da1a2011aa97a7dc7374d7b26c9a6dd Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 4 Jun 2025 00:19:29 -0700 Subject: [PATCH 2/5] fix: return absolute value Signed-off-by: Athan --- lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js index 76f9f6260e3a..7f02ae270848 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/accessors.js @@ -62,7 +62,7 @@ function nanmaxabs( N, x, strideX, offsetX ) { get = x.accessors[ 0 ]; if ( N === 1 || strideX === 0 ) { - return get( xbuf, offsetX ); + return abs( get( xbuf, offsetX ) ); } ix = offsetX; for ( i = 0; i < N; i++ ) { From 24efac53e72efbdf4930e9fc03215d937f104c54 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 4 Jun 2025 00:20:41 -0700 Subject: [PATCH 3/5] fix: return absolute value Signed-off-by: Athan --- lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js index ebbb52164dac..f7c56cc98079 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/lib/ndarray.js @@ -58,7 +58,7 @@ function nanmaxabs( N, x, strideX, offsetX ) { return accessors( N, o, strideX, offsetX ); } if ( N === 1 || strideX === 0 ) { - return x[ offsetX ]; + return abs( x[ offsetX ] ); } ix = offsetX; for ( i = 0; i < N; i++ ) { From b9ecf451ddf84c2c84332cf5a83216e8ec42c364 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 4 Jun 2025 00:22:45 -0700 Subject: [PATCH 4/5] test: update descriptions Signed-off-by: Athan --- .../stats/base/nanmaxabs/test/test.nanmaxabs.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js index ec72149c2fc7..0f2b8e162bea 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.nanmaxabs.js @@ -125,11 +125,11 @@ tape( 'if provided an `N` parameter less than or equal to `0`, the function retu t.end(); }); -tape( 'if provided an `N` parameter equal to `1`, the function returns the first element', function test( t ) { +tape( 'if provided an `N` parameter equal to `1`, the function returns the absolute value of the first element', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( 1, x, 1 ); t.strictEqual( v, 1.0, 'returns expected value' ); @@ -137,11 +137,11 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first t.end(); }); -tape( 'if provided an `N` parameter equal to `1`, the function returns the first element (accessors)', function test( t ) { +tape( 'if provided an `N` parameter equal to `1`, the function returns the absolute value of the first element (accessors)', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( 1, toAccessorArray( x ), 1 ); t.strictEqual( v, 1.0, 'returns expected value' ); @@ -241,11 +241,11 @@ tape( 'the function supports a negative `stride` parameter (accessors)', functio t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the absolute value of the first element', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( x.length, x, 0 ); t.strictEqual( v, 1.0, 'returns expected value' ); @@ -253,11 +253,11 @@ tape( 'if provided a `stride` parameter equal to `0`, the function returns the f t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first element (accessors)', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the absolute value of the first element (accessors)', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( x.length, toAccessorArray( x ), 0 ); t.strictEqual( v, 1.0, 'returns expected value' ); From 651416418b109a536d17ffbd606108d9ca37f73b Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 4 Jun 2025 00:24:09 -0700 Subject: [PATCH 5/5] test: update descriptions Signed-off-by: Athan --- .../stats/base/nanmaxabs/test/test.ndarray.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js index f1054fa915c9..aeb8d8addd6a 100644 --- a/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js +++ b/lib/node_modules/@stdlib/stats/base/nanmaxabs/test/test.ndarray.js @@ -124,11 +124,11 @@ tape( 'if provided an `N` parameter less than or equal to `0`, the function retu t.end(); }); -tape( 'if provided an `N` parameter equal to `1`, the function returns the first indexed element', function test( t ) { +tape( 'if provided an `N` parameter equal to `1`, the function returns the absolute value of the first indexed element', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( 1, x, 1, 0 ); t.strictEqual( v, 1.0, 'returns expected value' ); @@ -136,11 +136,11 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first t.end(); }); -tape( 'if provided an `N` parameter equal to `1`, the function returns the first indexed element (accessors)', function test( t ) { +tape( 'if provided an `N` parameter equal to `1`, the function returns the absolute value of the first indexed element (accessors)', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( 1, toAccessorArray( x ), 1, 0 ); t.strictEqual( v, 1.0, 'returns expected value' ); @@ -240,22 +240,22 @@ tape( 'the function supports a negative `stride` parameter (accessors)', functio t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the absolute value of the first indexed element', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( x.length, x, 0, 0 ); t.strictEqual( v, 1.0, 'returns expected value' ); t.end(); }); -tape( 'if provided a `stride` parameter equal to `0`, the function returns the first indexed element (accessors)', function test( t ) { +tape( 'if provided a `stride` parameter equal to `0`, the function returns the absolute value of the first indexed element (accessors)', function test( t ) { var x; var v; - x = [ 1.0, -2.0, -4.0, 5.0, 3.0 ]; + x = [ -1.0, -2.0, -4.0, 5.0, 3.0 ]; v = nanmaxabs( x.length, toAccessorArray( x ), 0, 0 ); t.strictEqual( v, 1.0, 'returns expected value' );