Skip to content

Commit 460ac0c

Browse files
authored
Merge pull request academicpages#2799 from HirokiHamaguchi/master
Fix several typos and bugs
2 parents e53c946 + b9e4c76 commit 460ac0c

16 files changed

+40
-37
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Academic Pages
2-
**Academic Pages is a Github Pages template for academic websites.**
2+
**Academic Pages is a GitHub Pages template for academic websites.**
33

44
![Academic Pages template example](images/homepage.png "Academic Pages template example")
55

_includes/archive-single-cv.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ <h3 class="archive__item-title" itemprop="headline">
3434
{% endif %}
3535
</h3>
3636
{% if post.read_time %}
37-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
37+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
3838
{% endif %}
3939
{% if post.venue%}<p class="archive__item-excerpt" itemprop="description">{{ post.citation }}</p> {% endif %}
4040
</li>

_includes/archive-single-talk-cv.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h3 class="archive__item-title" itemprop="headline">
3333
<a href="{{ base_path }}{{ post.url }}" rel="permalink">{{ title }}</a>
3434
{% endif %}
3535
</h3>
36-
{% if post.date %}<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {{ post.date | date: '%B %d, %Y' }}</p>{% endif %}
36+
{% if post.date %}<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {{ post.date | date: '%B %d, %Y' }}</p>{% endif %}
3737
{% if post.venue%}<p class="archive__item-excerpt" itemprop="description">{{post.type}} at {{ post.venue }}, {{post.location}}</p>{% endif %}
3838
</li>
3939
</article>

_includes/archive-single-talk.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ <h2 class="archive__item-title" itemprop="headline">
3333
{% endif %}
3434
</h2>
3535
{% if post.read_time %}
36-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
36+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
3737
{% endif %}
38-
{% if post.date %}<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {{ post.date | date: '%B %d, %Y' }}</p>{% endif %}
38+
{% if post.date %}<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {{ post.date | date: '%B %d, %Y' }}</p>{% endif %}
3939
{% if post.venue %}<p class="archive__item-excerpt" itemprop="description">{{post.type}}, {{ post.venue }}, {{post.location}} {% endif %}
4040
{% if post.excerpt %}<p class="archive__item-excerpt" itemprop="description">{{ post.excerpt | markdownify }}</p>{% endif %}
4141
</article>

_includes/archive-single.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ <h2 class="archive__item-title" itemprop="headline">
3535
</h2>
3636

3737
{% if post.read_time %}
38-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
38+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
3939
{% endif %}
4040

4141
{% if post.collection == 'teaching' %}

_includes/author-profile.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ <h3 class="author__name">{{ author.name }}</h3>
7474
<li><a href="https://dribbble.com/{{ author.dribbble }}"><i class="fab fa-fw fa-dribbble icon-pad-right" aria-hidden="true"></i>Dribbble</a></li>
7575
{% endif %}
7676
{% if author.github %}
77-
<li><a href="https://github.com/{{ author.github }}"><i class="fab fa-fw fa-github icon-pad-right" aria-hidden="true"></i>Github</a></li>
77+
<li><a href="https://github.com/{{ author.github }}"><i class="fab fa-fw fa-github icon-pad-right" aria-hidden="true"></i>GitHub</a></li>
7878
{% endif %}
7979
{% if author.kaggle %}
8080
<li><a href="https://kaggle.com/{{ author.kaggle }}"><i class="fab fa-fw fa-kaggle icon-pad-right" aria-hidden="true"></i>Kaggle</a></li>

_includes/page__hero.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ <h1 class="page__title" itemprop="headline">
4040
<p class="page__lead">{{ page.excerpt | markdownify | remove: "<p>" | remove: "</p>" }}</p>
4141
{% endif %}
4242
{% if site.read_time and page.read_time %}
43-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
43+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
4444
{% endif %}
4545
{% if page.header.cta_url %}
4646
<p><a href="{{ cta_path }}" class="btn btn--light-outline btn--large">{{ page.header.cta_label | default: site.data.ui-text[site.locale].more_label | default: "Learn More" }}</a></p>

_layouts/single.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<header>
2929
{% if page.title %}<h1 class="page__title" itemprop="headline">{{ page.title | markdownify | remove: "<p>" | remove: "</p>" }}</h1>{% endif %}
3030
{% if page.read_time %}
31-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
31+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
3232
{% endif %}
3333
{% if page.modified %}
3434
<p class="page__date"><strong><i class="fa fa-fw fa-calendar" aria-hidden="true"></i> {{ site.data.ui-text[site.locale].date_label | default: "Published:" }}</strong> <time datetime="{{ page.modified | date: "%Y-%m-%d" }}">{{ page.modified | date: "%B %d, %Y" }}</time></p>

_layouts/talk.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<header>
2929
{% if page.title %}<h1 class="page__title" itemprop="headline">{{ page.title | markdownify | remove: "<p>" | remove: "</p>" }}</h1>{% endif %}
3030
{% if page.read_time %}
31-
<p class="page__meta"><i class="fa fa-clock-o" aria-hidden="true"></i> {% include read-time.html %}</p>
31+
<p class="page__meta"><i class="fa fa-clock" aria-hidden="true"></i> {% include read-time.html %}</p>
3232
{% endif %}
3333
{% if page.modified %}
3434
<p class="page__date"><strong><i class="fa fa-fw fa-calendar" aria-hidden="true"></i>Date:</strong> <time datetime="{{ page.modified | date: "%Y-%m-%d" }}">{{ page.modified | date: "%B %d, %Y" }}</time></p>

_pages/archive-layout-with-content.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Make any link standout more when applying the `.btn` class.
105105

106106
### Anchor Tag (aka. Link)
107107

108-
This is an example of a [link](http://github.com "Github").
108+
This is an example of a [link](http://github.com "GitHub").
109109

110110
### Abbreviation Tag
111111

_pages/cv.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,17 @@ Education
1818
Work experience
1919
======
2020
* Spring 2024: Academic Pages Collaborator
21-
* Github University
21+
* GitHub University
2222
* Duties includes: Updates and improvements to template
2323
* Supervisor: The Users
2424

2525
* Fall 2015: Research Assistant
26-
* Github University
26+
* GitHub University
2727
* Duties included: Merging pull requests
2828
* Supervisor: Professor Hub
2929

3030
* Summer 2015: Research Assistant
31-
* Github University
31+
* GitHub University
3232
* Duties included: Tagging issues
3333
* Supervisor: Professor Git
3434

_pages/markdown.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ redirect_from:
2525
## Tips and hints
2626

2727
* Name a file ".md" to have it render in markdown, name it ".html" to render in HTML.
28-
* Go to the [commit list](https://github.com/academicpages/academicpages.github.io/commits/master) (on your repo) to find the last version Github built with Jekyll.
28+
* Go to the [commit list](https://github.com/academicpages/academicpages.github.io/commits/master) (on your repo) to find the last version GitHub built with Jekyll.
2929
* Green check: successful build
3030
* Orange circle: building
3131
* Red X: error
@@ -182,7 +182,7 @@ This is the regular text.[^1] This is more regular text.[^note]
182182

183183
### Anchor Tag (aka. Link)
184184

185-
This is an example of a [link](http://github.com "Github").
185+
This is an example of a [link](http://github.com "GitHub").
186186

187187
### Abbreviation Tag
188188

_pages/talkmap.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
author_profile: true
66
---
77

8-
<p>This map is generated from a Jupyter Notebook file in <a href="https://github.com/academicpages/academicpages.github.io/blob/master/_talks/talkmap.ipynb">/_talks/talkmap.ipynb</a>, which mines the location fields in the .md files in _talks/.</p>
8+
<p>This map is generated from a Jupyter Notebook file in <a href="https://github.com/academicpages/academicpages.github.io/blob/master/talkmap.ipynb">talkmap.ipynb</a>, which mines the location fields in the .md files in _talks/.</p>
99
<iframe src="/talkmap/map.html" height="700" width="850" style="border:none;"></iframe>

_sass/_variables.scss

+3-3
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ $x-large : 1280px !default;
132132
Grid
133133
========================================================================== */
134134

135-
$right-sidebar-width-narrow : 200px !default;
136-
$right-sidebar-width : 300px !default;
137-
$right-sidebar-width-wide : 400px !default;
135+
$right-sidebar-width-narrow : 20px !default;
136+
$right-sidebar-width : 30px !default;
137+
$right-sidebar-width-wide : 40px !default;
138138

139139
$susy: (
140140
columns: 12,

assets/js/main.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/js/plugins/jquery.greedy-navigation.js

+19-16
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,27 @@ function updateNav() {
1919
// The visible list is overflowing the nav
2020
if($vlinks.width() > availableSpace) {
2121

22-
// Record the width of the list
23-
breaks.push($vlinks.width());
22+
while ($vlinks.width() > availableSpace && $vlinks.children('*:not(.masthead__menu-item--lg)').length > 0) {
2423

25-
// Move item to the hidden list
26-
$vlinks.children('*:not(.masthead__menu-item--lg)').last().prependTo($hlinks);
24+
// Record the width of the list
25+
breaks.push($vlinks.width());
2726

28-
// Show the dropdown btn
29-
if($btn.hasClass('hidden')) {
30-
$btn.removeClass('hidden');
27+
// Move item to the hidden list
28+
$vlinks.children('*:not(.masthead__menu-item--lg)').last().prependTo($hlinks);
29+
30+
availableSpace = $btn.hasClass('hidden') ? $nav.width() : $nav.width() - $btn.width() - 30;
31+
32+
// Show the dropdown btn
33+
if($btn.hasClass('hidden')) {
34+
$btn.removeClass('hidden');
35+
}
3136
}
3237

33-
// The visible list is not overflowing
38+
// The visible list is not overflowing
3439
} else {
3540

3641
// There is space for another item in the nav
37-
if(availableSpace > breaks[breaks.length-1]) {
38-
42+
while(breaks.length > 0 && availableSpace > breaks[breaks.length-1]) {
3943
// Move the item to the visible list
4044
$hlinks.children().first().appendTo($vlinks);
4145
breaks.pop();
@@ -44,23 +48,22 @@ function updateNav() {
4448
// Hide the dropdown btn if hidden list is empty
4549
if(breaks.length < 1) {
4650
$btn.addClass('hidden');
51+
$btn.removeClass('close');
4752
$hlinks.addClass('hidden');
4853
}
4954
}
5055

5156
// Keep counter updated
5257
$btn.attr("count", breaks.length);
5358

54-
// Recur if the visible list is still overflowing the nav
55-
if($vlinks.width() > availableSpace) {
56-
updateNav();
57-
}
58-
5959
}
6060

6161
// Window listeners
6262

63-
$(window).resize(function() {
63+
$(window).on('resize', function() {
64+
updateNav();
65+
});
66+
screen.orientation.addEventListener("change", function(){
6467
updateNav();
6568
});
6669

0 commit comments

Comments
 (0)