clean

Author: burrbull

src/spi.rs

@@ -370,8 +370,6 @@ where
             loop {
                 let sr = self.spi.sr.read();
                 if sr.txe().bit_is_set() {
-                    // NOTE(write_volatile) see note above
-                    // unsafe { ptr::write_volatile(&self.spi.dr as *const _ as *mut u8, *word) }
                     self.write_data_reg(*word);
                     if sr.modf().bit_is_set() {
                         return Err(Error::ModeFault);
@@ -381,24 +379,10 @@ where
             }
         }
         // Wait for final TXE
-        loop {
-            let sr = self.spi.sr.read();
-            if sr.txe().bit_is_set() {
-                break;
-            }
-        }
+        while self.spi.sr.read().txe().bit_is_clear() { }
         // Wait for final !BSY
-        loop {
-            let sr = self.spi.sr.read();
-            if !sr.bsy().bit_is_set() {
-                break;
-            }
-        }
+        while self.spi.sr.read().bsy().bit_is_set() { }
         // Clear OVR set due to dropped received values
-        // NOTE(read_volatile) see note above
-        // unsafe {
-        //     let _ = ptr::read_volatile(&self.spi.dr as *const _ as *const u8);
-        // }
         let _ = self.read_data_reg();
         let _ = self.spi.sr.read();
         Ok(())