From 614c80698d584e6398c9ededdc604f8f43ff293c Mon Sep 17 00:00:00 2001 From: robertjd Date: Thu, 30 Jun 2016 12:02:10 -0700 Subject: [PATCH 1/4] Proposed validation error for SAML configuration WRT callback URI --- configuration.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/configuration.md b/configuration.md index 81bc4b0..c50297c 100644 --- a/configuration.md +++ b/configuration.md @@ -79,3 +79,7 @@ this exception should be thrown: > No default account store is mapped to the specified application. A default account store is required for registration. + +* If SAML directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this error should be thrown: + + > stormpath.web.callback.enabled is set to false, but SAML directories are mapped to this application. SAML workflows cannot be completed if this callback endpoint is disabled. From bd4227a7c612979a7bacc14c4a3fda326aee431a Mon Sep 17 00:00:00 2001 From: robertjd Date: Thu, 7 Jul 2016 11:23:06 -0700 Subject: [PATCH 2/4] change to warn instead of error --- configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration.md b/configuration.md index c50297c..d4e8586 100644 --- a/configuration.md +++ b/configuration.md @@ -80,6 +80,6 @@ this exception should be thrown: > No default account store is mapped to the specified application. A default account store is required for registration. -* If SAML directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this error should be thrown: +* If SAML directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this warning should be logged: > stormpath.web.callback.enabled is set to false, but SAML directories are mapped to this application. SAML workflows cannot be completed if this callback endpoint is disabled. From b9e44114421e98e3ab7391b93db847eaf4ea87b8 Mon Sep 17 00:00:00 2001 From: robertjd Date: Thu, 7 Jul 2016 11:23:41 -0700 Subject: [PATCH 3/4] saml -> external providers --- configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration.md b/configuration.md index d4e8586..be34a70 100644 --- a/configuration.md +++ b/configuration.md @@ -80,6 +80,6 @@ this exception should be thrown: > No default account store is mapped to the specified application. A default account store is required for registration. -* If SAML directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this warning should be logged: +* If external provider directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this warning should be logged: > stormpath.web.callback.enabled is set to false, but SAML directories are mapped to this application. SAML workflows cannot be completed if this callback endpoint is disabled. From 7d80ad3deea984c170943032f7504b9586923c29 Mon Sep 17 00:00:00 2001 From: robertjd Date: Thu, 7 Jul 2016 11:24:06 -0700 Subject: [PATCH 4/4] saml -> provider login --- configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration.md b/configuration.md index be34a70..31db056 100644 --- a/configuration.md +++ b/configuration.md @@ -82,4 +82,4 @@ this exception should be thrown: * If external provider directories are mapped to the application, but `stormpath.web.callback.enabled` has been set to `false`, the end user cannot complete the SAML workflow and this warning should be logged: - > stormpath.web.callback.enabled is set to false, but SAML directories are mapped to this application. SAML workflows cannot be completed if this callback endpoint is disabled. + > stormpath.web.callback.enabled is set to false, but SAML directories are mapped to this application. Provider login workflows cannot be completed if this callback endpoint is disabled.