core/state: logic equivalence for GetCodeHash (ethereum#28733)

cygaar · Roberto Bayardo · commit 052f558eadce · 2024-04-02T15:17:52.000-07:00
diff --git a/core/state/statedb.go b/core/state/statedb.go
@@ -331,10 +331,10 @@ func (s *StateDB) GetCodeSize(addr common.Address) int {
 
 func (s *StateDB) GetCodeHash(addr common.Address) common.Hash {
 	stateObject := s.getStateObject(addr)
-	if stateObject == nil {
-		return common.Hash{}
+	if stateObject != nil {
+		return common.BytesToHash(stateObject.CodeHash())
 	}
-	return common.BytesToHash(stateObject.CodeHash())
+	return common.Hash{}
 }
 
 // GetState retrieves a value from the given account's storage trie.

Original file line number	Diff line number	Diff line change
`@@ -331,10 +331,10 @@ func (s *StateDB) GetCodeSize(addr common.Address) int {`
`331`	`331`
`332`	`332`	`func (s *StateDB) GetCodeHash(addr common.Address) common.Hash {`
`333`	`333`	`stateObject := s.getStateObject(addr)`
`334`		`- if stateObject == nil {`
`335`		`- return common.Hash{}`
	`334`	`+ if stateObject != nil {`
	`335`	`+ return common.BytesToHash(stateObject.CodeHash())`
`336`	`336`	`}`
`337`		`- return common.BytesToHash(stateObject.CodeHash())`
	`337`	`+ return common.Hash{}`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`// GetState retrieves a value from the given account's storage trie.`