Skip to content

Commit 1ecd116

Browse files
ob-stripeob-stripe
authored
Merge pull request #470 from stripe/ob-lint
Remove unused code
2 parents 7512f09 + addbbfc commit 1ecd116

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+18
-156
lines changed

‎src/main/java/com/stripe/model/Address.java

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.stripe.model;
22

3-
import com.stripe.net.APIResource;
4-
53
public final class Address extends StripeObject {
64
protected String city;
75
protected String country;

‎src/main/java/com/stripe/model/AlipayAccount.java

-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
package com.stripe.model;
22

3-
import com.stripe.Stripe;
43
import com.stripe.exception.APIConnectionException;
54
import com.stripe.exception.APIException;
65
import com.stripe.exception.AuthenticationException;
76
import com.stripe.exception.CardException;
87
import com.stripe.exception.InvalidRequestException;
98
import com.stripe.net.RequestOptions;
109

11-
import java.util.Collections;
12-
import java.util.HashMap;
1310
import java.util.Map;
1411

1512
public class AlipayAccount extends ExternalAccount {

‎src/main/java/com/stripe/model/BalanceTransaction.java

-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ public static BalanceTransaction retrieve(String id) throws AuthenticationExcept
177177
public static BalanceTransaction retrieve(String id, String apiKey)
178178
throws AuthenticationException, InvalidRequestException,
179179
APIConnectionException, CardException, APIException {
180-
String url = String.format("%s/%s/%s", Stripe.getApiBase(), "v1/balance/history", id);
181180
return retrieve(id, RequestOptions.builder().setApiKey(apiKey).build());
182181
}
183182

‎src/main/java/com/stripe/model/BitcoinReceiver.java

-2
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@
66
import com.stripe.exception.AuthenticationException;
77
import com.stripe.exception.CardException;
88
import com.stripe.exception.InvalidRequestException;
9-
import com.stripe.net.APIResource;
109
import com.stripe.net.RequestOptions;
1110

12-
import java.util.Collections;
1311
import java.util.Map;
1412

1513
public class BitcoinReceiver extends ExternalAccount {

‎src/main/java/com/stripe/model/BitcoinTransaction.java

-10
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,6 @@
11
package com.stripe.model;
22

3-
import com.stripe.Stripe;
4-
import com.stripe.exception.APIConnectionException;
5-
import com.stripe.exception.APIException;
6-
import com.stripe.exception.AuthenticationException;
7-
import com.stripe.exception.CardException;
8-
import com.stripe.exception.InvalidRequestException;
93
import com.stripe.net.APIResource;
10-
import com.stripe.net.RequestOptions;
11-
12-
import java.util.Collections;
13-
import java.util.Map;
144

155
public class BitcoinTransaction extends APIResource implements HasId {
166
String id;

‎src/main/java/com/stripe/model/Customer.java

-1
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ public Customer update(Map<String, Object> params, RequestOptions options)
453453
public DeletedCustomer delete(String apiKey)
454454
throws AuthenticationException, InvalidRequestException,
455455
APIConnectionException, CardException, APIException {
456-
RequestOptions result = null;
457456
return delete(RequestOptions.builder().setApiKey(apiKey).build());
458457
}
459458

‎src/main/java/com/stripe/model/EventRequestDeserializer.java

-2
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@
77
import com.google.gson.JsonDeserializer;
88
import com.google.gson.JsonElement;
99
import com.google.gson.JsonParseException;
10-
import com.google.gson.reflect.TypeToken;
1110

1211
import java.lang.reflect.Type;
13-
import java.util.List;
1412

1513
public class EventRequestDeserializer implements JsonDeserializer<EventRequest> {
1614

‎src/main/java/com/stripe/model/ExchangeRate.java

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.stripe.model;
22

3-
import com.stripe.Stripe;
43
import com.stripe.exception.APIConnectionException;
54
import com.stripe.exception.APIException;
65
import com.stripe.exception.AuthenticationException;

‎src/main/java/com/stripe/model/ExpandableFieldSerializer.java

-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
import java.lang.reflect.Type;
66

7-
import com.stripe.model.StripeObject;
8-
97
public class ExpandableFieldSerializer implements JsonSerializer<ExpandableField> {
108
public JsonElement serialize(ExpandableField src, Type typeOfSrc, JsonSerializationContext context) {
119
if (src.isExpanded()) {

‎src/main/java/com/stripe/model/ExternalAccount.java

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.stripe.model;
22

3-
import com.stripe.Stripe;
43
import com.stripe.exception.APIConnectionException;
54
import com.stripe.exception.APIException;
65
import com.stripe.exception.AuthenticationException;
@@ -9,7 +8,6 @@
98
import com.stripe.net.APIResource;
109
import com.stripe.net.RequestOptions;
1110

12-
import java.util.Collections;
1311
import java.util.Map;
1412

1513
public class ExternalAccount extends APIResource implements HasId, MetadataStore<ExternalAccount> {

‎src/main/java/com/stripe/model/LegalEntity.java

-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
package com.stripe.model;
22

3-
import com.stripe.exception.APIConnectionException;
4-
import com.stripe.exception.APIException;
5-
import com.stripe.exception.AuthenticationException;
6-
import com.stripe.exception.CardException;
7-
import com.stripe.exception.InvalidRequestException;
8-
import com.stripe.net.APIResource;
9-
import com.stripe.net.RequestOptions;
10-
113
import java.util.List;
12-
import java.util.Map;
134

145
import com.google.gson.annotations.SerializedName;
156

‎src/main/java/com/stripe/model/LoginLink.java

-8
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
package com.stripe.model;
22

3-
import com.stripe.exception.APIConnectionException;
4-
import com.stripe.exception.APIException;
5-
import com.stripe.exception.AuthenticationException;
6-
import com.stripe.exception.CardException;
7-
import com.stripe.exception.InvalidRequestException;
83
import com.stripe.net.APIResource;
9-
import com.stripe.net.RequestOptions;
10-
11-
import java.util.Map;
124

135
public class LoginLink extends APIResource implements HasId {
146
String object;

‎src/main/java/com/stripe/model/LoginLinkCollection.java

-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import com.stripe.net.APIResource;
1010
import com.stripe.net.RequestOptions;
1111

12-
import java.util.Map;
13-
1412
public class LoginLinkCollection extends StripeCollection<LoginLink> {
1513
public LoginLink create()
1614
throws AuthenticationException, InvalidRequestException,

‎src/main/java/com/stripe/model/Payout.java

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.stripe.net.APIResource;
99
import com.stripe.net.RequestOptions;
1010

11-
import java.util.List;
1211
import java.util.Map;
1312

1413
public class Payout extends APIResource implements MetadataStore<Payout>, HasId {

‎src/main/java/com/stripe/model/RefundCollection.java

-10
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,4 @@
11
package com.stripe.model;
22

3-
import com.stripe.Stripe;
4-
import com.stripe.exception.APIConnectionException;
5-
import com.stripe.exception.APIException;
6-
import com.stripe.exception.AuthenticationException;
7-
import com.stripe.exception.CardException;
8-
import com.stripe.exception.InvalidRequestException;
9-
import com.stripe.net.RequestOptions;
10-
11-
import java.util.Map;
12-
133
public class RefundCollection extends StripeCollection<Refund> {
144
}

‎src/main/java/com/stripe/model/Source.java

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.stripe.exception.InvalidRequestException;
88
import com.stripe.net.RequestOptions;
99

10-
import java.io.IOException;
1110
import java.util.Map;
1211

1312
public class Source extends ExternalAccount implements HasSourceTypeData {

‎src/main/java/com/stripe/model/SourceMandateNotification.java

-6
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22

33
import java.util.Map;
44

5-
import com.stripe.exception.APIConnectionException;
6-
import com.stripe.exception.APIException;
7-
import com.stripe.exception.AuthenticationException;
8-
import com.stripe.exception.CardException;
9-
import com.stripe.exception.InvalidRequestException;
105
import com.stripe.net.APIResource;
11-
import com.stripe.net.RequestOptions;
126

137

148
public class SourceMandateNotification extends APIResource implements HasId, HasSourceTypeData {

‎src/main/java/com/stripe/model/SourceTransaction.java

-6
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22

33
import java.util.Map;
44

5-
import com.stripe.exception.APIConnectionException;
6-
import com.stripe.exception.APIException;
7-
import com.stripe.exception.AuthenticationException;
8-
import com.stripe.exception.CardException;
9-
import com.stripe.exception.InvalidRequestException;
105
import com.stripe.net.APIResource;
11-
import com.stripe.net.RequestOptions;
126

137

148
public class SourceTransaction extends APIResource implements HasId, HasSourceTypeData {

‎src/main/java/com/stripe/model/StripeCollection.java

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.stripe.net.RequestOptions;
44

5-
import java.util.Iterator;
65
import java.util.List;
76
import java.util.Map;
87

‎src/main/java/com/stripe/model/SubscriptionItem.java

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import com.stripe.net.RequestOptions;
1010

1111
import java.util.Map;
12-
import java.util.List;
1312

1413

1514
public class SubscriptionItem extends APIResource implements HasId {

‎src/main/java/com/stripe/model/VerificationFields.java

-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
package com.stripe.model;
22

3-
import com.google.gson.annotations.SerializedName;
4-
5-
import java.util.List;
6-
73
public final class VerificationFields extends StripeObject {
84
protected VerificationFieldsDetails individual;
95
protected VerificationFieldsDetails company;

‎src/main/java/com/stripe/model/VerificationFieldsDetails.java

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package com.stripe.model;
22

3-
import com.google.gson.annotations.SerializedName;
4-
53
import java.util.List;
64

75
public final class VerificationFieldsDetails extends StripeObject {

‎src/main/java/com/stripe/net/StripeSSLSocketFactory.java

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.io.IOException;
88
import java.net.InetAddress;
99
import java.net.Socket;
10-
import java.net.UnknownHostException;
1110
import java.security.NoSuchAlgorithmException;
1211
import java.util.Arrays;
1312
import java.util.HashSet;

‎src/main/java/com/stripe/net/Webhook.java

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.stripe.exception.SignatureVerificationException;
44
import com.stripe.model.Event;
5-
import com.stripe.model.StripeObject;
65

76
import java.io.UnsupportedEncodingException;
87
import java.util.ArrayList;

‎src/test/java/com/stripe/functional/AccountTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import java.util.Map;
1111
import java.util.regex.Pattern;
1212

13-
import static org.junit.Assert.assertEquals;
1413
import static org.junit.Assert.assertTrue;
1514

1615
public class AccountTest extends BaseStripeFunctionalTest {

‎src/test/java/com/stripe/functional/ApplicationFeeTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.junit.Test;
88

99
import java.util.HashMap;
10-
import java.util.List;
1110
import java.util.Map;
1211

1312
import static org.junit.Assert.assertEquals;

‎src/test/java/com/stripe/functional/ChargeTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ public void testInvalidCard() throws StripeException {
155155
public void testDeclinedCard() throws StripeException {
156156
Map<String, Object> declinedChargeParams = new HashMap<String, Object>();
157157
declinedChargeParams.putAll(defaultChargeParams);
158-
Map<String, Object> declinedCardParams = new HashMap<String, Object>();
159158
declinedChargeParams.put("source", "tok_chargeDeclined");
160159

161160
try {
@@ -170,7 +169,6 @@ public void testDeclinedCard() throws StripeException {
170169
public void testInvalidAddressZipTest() throws StripeException {
171170
Map<String, Object> invalidChargeParams = new HashMap<String, Object>();
172171
invalidChargeParams.putAll(defaultChargeParams);
173-
Map<String, Object> invalidCardParams = new HashMap<String, Object>();
174172
invalidChargeParams.put("source", "tok_avsZipFail");
175173
Charge charge = Charge.create(invalidChargeParams, supportedRequestOptions);
176174
assertEquals(charge.getPaid(), true);
@@ -184,7 +182,6 @@ public void testInvalidAddressZipTest() throws StripeException {
184182
public void testInvalidAddressLine1Test() throws StripeException {
185183
Map<String, Object> invalidChargeParams = new HashMap<String, Object>();
186184
invalidChargeParams.putAll(defaultChargeParams);
187-
Map<String, Object> invalidCardParams = new HashMap<String, Object>();
188185
invalidChargeParams.put("source", "tok_avsLine1Fail");
189186
Charge charge = Charge.create(invalidChargeParams, supportedRequestOptions);
190187
assertEquals(charge.getPaid(), true);

‎src/test/java/com/stripe/functional/DisputeTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.google.common.collect.ImmutableMap;
44
import com.stripe.BaseStripeFunctionalTest;
5-
import com.stripe.Stripe;
65
import com.stripe.exception.*;
76
import com.stripe.model.*;
87
import com.stripe.net.RequestOptions;

‎src/test/java/com/stripe/functional/SubscriptionItemTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void testSubscriptionItemRetrieve() throws StripeException {
6262
public void testSubscriptionItemList() throws StripeException {
6363
Customer customer = Customer.create(defaultCustomerParams);
6464
Subscription subscription = createDefaultSubscription(customer);
65-
SubscriptionItem subscriptionItem = createDefaultSubscriptionItem(subscription);
65+
createDefaultSubscriptionItem(subscription);
6666

6767
Map<String, Object> listParams = new HashMap<String, Object>();
6868
listParams.put("subscription", subscription.getId());

‎src/test/java/com/stripe/model/AccountTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public void testAccountCreateLoginLink() throws StripeException, IOException {
188188

189189
String json_link = resource("login_link.json");
190190
stubNetwork(LoginLink.class, json_link);
191-
LoginLink link = acc.getLoginLinks().create();
191+
acc.getLoginLinks().create();
192192
verifyPost(LoginLink.class, "https://api.stripe.com/v1/accounts/acct_EXPRESS/login_links", (RequestOptions) null);
193193
}
194194
}

‎src/test/java/com/stripe/model/CardTest.java

-2
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package com.stripe.model;
22

33
import com.stripe.BaseStripeTest;
4-
import com.stripe.exception.StripeException;
54
import com.stripe.net.APIResource;
65
import org.junit.Before;
76
import org.junit.Test;
87

98
import java.io.IOException;
109

1110
import static org.junit.Assert.assertEquals;
12-
import static org.junit.Assert.assertTrue;
1311

1412
public class CardTest extends BaseStripeTest {
1513
Card card;

‎src/test/java/com/stripe/model/ChargeTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.stripe.model;
22

33
import com.stripe.BaseStripeTest;
4-
import com.stripe.exception.StripeException;
54
import com.stripe.net.APIResource;
65
import org.junit.Before;
76
import org.junit.Test;

‎src/test/java/com/stripe/model/ExchangeRateTest.java

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
11
package com.stripe.model;
22

3-
import java.io.IOException;
43
import java.util.HashMap;
5-
import java.util.LinkedList;
6-
import java.util.Map;
74

85
import com.stripe.BaseStripeTest;
96
import com.stripe.exception.StripeException;
10-
import com.stripe.exception.InvalidRequestException;
117
import com.stripe.net.APIResource;
128
import com.stripe.net.LiveStripeResponseGetter;
13-
import com.stripe.net.RequestOptions;
14-
import com.stripe.net.RequestOptions.RequestOptionsBuilder;
159

1610
import org.junit.After;
1711
import org.junit.Before;
1812
import org.junit.Test;
1913

20-
import static org.junit.Assert.assertEquals;
2114
import static org.mockito.Mockito.*;
2215

2316
public class ExchangeRateTest extends BaseStripeTest {
@@ -34,7 +27,7 @@ public void unmockStripeResponseGetter() {
3427

3528
@Test
3629
public void testRetrieve() throws StripeException {
37-
ExchangeRate rates = ExchangeRate.retrieve("usd");
30+
ExchangeRate.retrieve("usd");
3831

3932
verifyGet(ExchangeRate.class, "https://api.stripe.com/v1/exchange_rates/usd");
4033
verifyNoMoreInteractions(networkMock);
@@ -45,7 +38,7 @@ public void testList() throws StripeException {
4538
HashMap<String, Object> params = new HashMap<String, Object>();
4639
params.put("limit", 3);
4740

48-
ExchangeRateCollection listRates = ExchangeRate.list(params);
41+
ExchangeRate.list(params);
4942

5043
verifyGet(ExchangeRateCollection.class, "https://api.stripe.com/v1/exchange_rates", params);
5144
verifyNoMoreInteractions(networkMock);

0 commit comments

Comments
 (0)