fixed: process leak on linux in foxytest

Author: strowk

pkg/foxytest/add_to_group_darwin.go

@@ -0,0 +1,10 @@
+package foxytest
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+func addToGroup(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}

pkg/foxytest/add_to_group_linux.go

@@ -0,0 +1,10 @@
+package foxytest
+
+import (
+	"os/exec"
+	"syscall"
+)
+
+func addToGroup(cmd *exec.Cmd) {
+	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
+}

pkg/foxytest/add_to_group_windows.go

@@ -0,0 +1,9 @@
+package foxytest
+
+import (
+	"os/exec"
+)
+
+func addToGroup(cmd *exec.Cmd) {
+	// just dummy that should not do anything, as windows already works like this
+}

pkg/foxytest/stop_darwin.go

@@ -6,5 +6,5 @@ import (
 )
 
 func stop(process *os.Process) error {
-	return process.Signal(syscall.SIGTERM)
+	return syscall.Kill(-process.Pid, syscall.SIGTERM)
 }

pkg/foxytest/stop_linux.go

@@ -6,5 +6,5 @@ import (
 )
 
 func stop(process *os.Process) error {
-	return process.Signal(syscall.SIGTERM)
+	return syscall.Kill(-process.Pid, syscall.SIGTERM)
 }

pkg/foxytest/testsuite.go

@@ -561,6 +561,8 @@ func (ts *testSuite) pipeOutput(t TestRunner) {
 func (ts *testSuite) startExecutable(t TestRunner) *exec.Cmd {
 	//nolint:gosec // #nosec G204 -- user gives us this command to run, so they must be sure to want to run it
 	cmd := exec.Command(ts.command, ts.args...)
+	addToGroup(cmd)
+
 	in, err := cmd.StdinPipe()
 	if err != nil {
 		t.Fatalf("error creating stdin pipe: %v", err)