refactor: remove code smell java:S5786 (iluwatar#2159)

https://sonarcloud.io/organizations/iluwatar/rules?open=java%3AS5786&rule_key=java%3AS5786

Author: robertvolkmann

acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitorTest.java

@@ -74,7 +74,7 @@ void testVisitForHayes() {
 
   @BeforeEach
   @AfterEach
-  public void clearLoggers() {
+  void clearLoggers() {
     TestLoggerFactory.clear();
   }
 }

acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitorTest.java

@@ -44,7 +44,7 @@ class ConfigureForUnixVisitorTest {
 
   @BeforeEach
   @AfterEach
-  public void clearLoggers() {
+  void clearLoggers() {
     TestLoggerFactory.clear();
   }
 

adapter/src/test/java/com/iluwatar/adapter/AdapterPatternTest.java

@@ -48,7 +48,7 @@ class AdapterPatternTest {
    * This method runs before the test execution and sets the bean objects in the beans Map.
    */
   @BeforeEach
-  public void setup() {
+  void setup() {
     beans = new HashMap<>();
 
     var fishingBoatAdapter = spy(new FishingBoatAdapter());

aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java

@@ -48,7 +48,7 @@ class AggregatorTest {
   private ProductInventoryClient inventoryClient;
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     MockitoAnnotations.openMocks(this);
   }
 

api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java

@@ -48,7 +48,7 @@ class ApiGatewayTest {
   private PriceClient priceClient;
 
   @BeforeEach
-  public void setup() {
+  void setup() {
     MockitoAnnotations.openMocks(this);
   }
 

business-delegate/src/test/java/com/iluwatar/business/delegate/BusinessDelegateTest.java

@@ -49,7 +49,7 @@ class BusinessDelegateTest {
    * execution of every test.
    */
   @BeforeEach
-  public void setup() {
+  void setup() {
     netflixService = spy(new NetflixService());
     youTubeService = spy(new YouTubeService());
 

caching/src/test/java/com/iluwatar/caching/CachingTest.java

@@ -39,7 +39,7 @@ class CachingTest {
    * Setup of application test includes: initializing DB connection and cache size/capacity.
    */
   @BeforeEach
-  public void setUp() {
+  void setUp() {
     // VirtualDB (instead of MongoDB) was used in running the JUnit tests
     // to avoid Maven compilation errors. Set flag to true to run the
     // tests with MongoDB (provided that MongoDB is installed and socket

callback/src/test/java/com/iluwatar/callback/CallbackTest.java

@@ -34,7 +34,7 @@
  * <p>
  * Could be done with mock objects as well where the call method call is verified.
  */
-public class CallbackTest {
+class CallbackTest {
 
   private Integer callingCount = 0;
 

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/AppTest.java

@@ -34,7 +34,7 @@
 /**
  * App Test showing usage of circuit breaker.
  */
-public class AppTest {
+class AppTest {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class);
 
@@ -60,7 +60,7 @@ public class AppTest {
    * and retry time period of 2 seconds.
    */
   @BeforeEach
-  public void setupCircuitBreakers() {
+  void setupCircuitBreakers() {
     var delayedService = new DelayedRemoteService(System.nanoTime(), STARTUP_DELAY);
     //Set the circuit Breaker parameters
     delayedServiceCircuitBreaker = new DefaultCircuitBreaker(delayedService, 3000,
@@ -78,7 +78,7 @@ public void setupCircuitBreakers() {
   }
 
   @Test
-  public void testFailure_OpenStateTransition() {
+  void testFailure_OpenStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -93,7 +93,7 @@ public void testFailure_OpenStateTransition() {
   }
 
   @Test
-  public void testFailure_HalfOpenStateTransition() {
+  void testFailure_HalfOpenStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -112,7 +112,7 @@ public void testFailure_HalfOpenStateTransition() {
   }
 
   @Test
-  public void testRecovery_ClosedStateTransition() {
+  void testRecovery_ClosedStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/DefaultCircuitBreakerTest.java

@@ -31,7 +31,7 @@
 /**
  * Circuit Breaker test
  */
-public class DefaultCircuitBreakerTest {
+class DefaultCircuitBreakerTest {
 
   //long timeout, int failureThreshold, long retryTimePeriod
   @Test

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/DelayedRemoteServiceTest.java

@@ -53,7 +53,7 @@ void testDefaultConstructor() throws RemoteServiceException {
    * @throws RemoteServiceException
    */
   @Test
-  public void testParameterizedConstructor() throws RemoteServiceException {
+  void testParameterizedConstructor() throws RemoteServiceException {
       var obj = new DelayedRemoteService(System.nanoTime()-2000*1000*1000,1);
       assertEquals("Delayed service is working",obj.call());
   }

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/consumer/callcostprocessor/functions/UsageCostProcessorFunctionTest.java

@@ -58,7 +58,7 @@
  * Unit test for Function class.
  */
 @ExtendWith(MockitoExtension.class)
-public class UsageCostProcessorFunctionTest {
+class UsageCostProcessorFunctionTest {
 
     @Mock
     MessageHandlerUtility<UsageDetail> mockMessageHandlerUtilityForUsageADetail;
@@ -74,7 +74,7 @@ public class UsageCostProcessorFunctionTest {
     UsageCostProcessorFunction usageCostProcessorFunction;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         var messageBodyUsageDetail = new MessageBody<UsageDetail>();
         var usageDetailsList = new ArrayList<UsageDetail>();
 
@@ -122,7 +122,7 @@ public void setUp() {
      * Unit test for HttpTriggerJava method.
      */
     @Test
-    public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")
@@ -148,7 +148,7 @@ public HttpResponseMessage.Builder answer(InvocationOnMock invocation) {
     }
 
     @Test
-    public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
         // Setup
         @SuppressWarnings("unchecked")
         final HttpRequestMessage<Optional<String>> req = mock(HttpRequestMessage.class);

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/producer/calldetails/functions/UsageDetailPublisherFunctionTest.java

@@ -52,7 +52,7 @@
  * Unit test for Function class.
  */
 @ExtendWith(MockitoExtension.class)
-public class UsageDetailPublisherFunctionTest {
+class UsageDetailPublisherFunctionTest {
     @Mock
     MessageHandlerUtility<UsageDetail> mockMessageHandlerUtility;
     @Mock
@@ -65,7 +65,7 @@ public class UsageDetailPublisherFunctionTest {
      * Unit test for HttpTriggerJava method.
      */
     @Test
-    public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")
@@ -91,7 +91,7 @@ public HttpResponseMessage.Builder answer(InvocationOnMock invocation) {
     }
 
     @Test
-    public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/utility/EventHandlerUtilityTest.java

@@ -40,7 +40,7 @@
 import org.mockito.junit.jupiter.MockitoExtension;
 
 @ExtendWith(MockitoExtension.class)
-public class EventHandlerUtilityTest {
+class EventHandlerUtilityTest {
 
     @Mock
     EventGridPublisherClient<BinaryData> mockCustomEventClient;
@@ -49,7 +49,7 @@ public class EventHandlerUtilityTest {
     EventHandlerUtility<Message<UsageDetail>> eventHandlerUtility;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
 
         System.setProperty("EventGridURL", "https://www.dummyEndpoint.com/api/events");
         System.setProperty("EventGridKey", "EventGridURL");

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/utility/MessageHandlerUtilityTest.java

@@ -46,7 +46,7 @@
 import static org.mockito.Mockito.*;
 
 @ExtendWith(MockitoExtension.class)
-public class MessageHandlerUtilityTest {
+class MessageHandlerUtilityTest {
     @Mock
     private BlobClient mockBlobClient;
 
@@ -63,7 +63,7 @@ public class MessageHandlerUtilityTest {
     private MessageReference messageReference;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         System.setProperty("BlobStorageConnectionString", "https://www.dummyEndpoint.com/api/blobs");
 
         var messageBody = new MessageBody<UsageDetail>();

composite-view/src/test/java/com/iluwatar/compositeview/AppServletTest.java

@@ -39,15 +39,15 @@
 and https://stackoverflow.com/questions/50211433/servlets-unit-testing
  */
 
-public class AppServletTest extends Mockito{
+class AppServletTest extends Mockito{
   private String msgPartOne = "<h1>This Server Doesn't Support";
   private String msgPartTwo = "Requests</h1>\n"
       + "<h2>Use a GET request with boolean values for the following parameters<h2>\n"
       + "<h3>'name'</h3>\n<h3>'bus'</h3>\n<h3>'sports'</h3>\n<h3>'sci'</h3>\n<h3>'world'</h3>";
   private String destination = "newsDisplay.jsp";
 
   @Test
-  public void testDoGet() throws Exception {
+  void testDoGet() throws Exception {
     HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
     HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
     RequestDispatcher mockDispatcher = Mockito.mock(RequestDispatcher.class);
@@ -64,7 +64,7 @@ public void testDoGet() throws Exception {
   }
 
   @Test
-  public void testDoPost() throws Exception {
+  void testDoPost() throws Exception {
     HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
     HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
     StringWriter stringWriter = new StringWriter();
@@ -78,7 +78,7 @@ public void testDoPost() throws Exception {
   }
 
   @Test
-  public void testDoPut() throws Exception {
+  void testDoPut() throws Exception {
     HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
     HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
     StringWriter stringWriter = new StringWriter();
@@ -92,7 +92,7 @@ public void testDoPut() throws Exception {
   }
 
   @Test
-  public void testDoDelete() throws Exception {
+  void testDoDelete() throws Exception {
     HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
     HttpServletResponse mockResp = Mockito.mock(HttpServletResponse.class);
     StringWriter stringWriter = new StringWriter();

composite-view/src/test/java/com/iluwatar/compositeview/JavaBeansTest.java

@@ -30,9 +30,9 @@
 
 import static org.junit.Assert.*;
 
-public class JavaBeansTest {
+class JavaBeansTest {
     @Test
-    public void testDefaultConstructor() {
+    void testDefaultConstructor() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertEquals("DEFAULT_NAME", newBean.getName());
         assertTrue(newBean.isBusinessInterest());
@@ -43,47 +43,47 @@ public void testDefaultConstructor() {
     }
 
     @Test
-    public void testNameGetterSetter() {
+    void testNameGetterSetter() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertEquals("DEFAULT_NAME", newBean.getName());
         newBean.setName("TEST_NAME_ONE");
         assertEquals("TEST_NAME_ONE", newBean.getName());
     }
 
     @Test
-    public void testBusinessSetterGetter() {
+    void testBusinessSetterGetter() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertTrue(newBean.isBusinessInterest());
         newBean.setBusinessInterest(false);
         assertFalse(newBean.isBusinessInterest());
     }
 
     @Test
-    public void testScienceSetterGetter() {
+    void testScienceSetterGetter() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertTrue(newBean.isScienceNewsInterest());
         newBean.setScienceNewsInterest(false);
         assertFalse(newBean.isScienceNewsInterest());
     }
 
     @Test
-    public void testSportsSetterGetter() {
+    void testSportsSetterGetter() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertTrue(newBean.isSportsInterest());
         newBean.setSportsInterest(false);
         assertFalse(newBean.isSportsInterest());
     }
 
     @Test
-    public void testWorldSetterGetter() {
+    void testWorldSetterGetter() {
         ClientPropertiesBean newBean = new ClientPropertiesBean();
         assertTrue(newBean.isWorldNewsInterest());
         newBean.setWorldNewsInterest(false);
         assertFalse(newBean.isWorldNewsInterest());
     }
 
     @Test
-    public void testRequestConstructor(){
+    void testRequestConstructor(){
         HttpServletRequest mockReq = Mockito.mock(HttpServletRequest.class);
         ClientPropertiesBean newBean = new ClientPropertiesBean((mockReq));
         assertEquals("DEFAULT_NAME", newBean.getName());

dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java

@@ -70,15 +70,15 @@ void createSchema() throws SQLException {
    * Represents the scenario where DB connectivity is present.
    */
   @Nested
-  public class ConnectionSuccess {
+  class ConnectionSuccess {
 
     /**
      * Setup for connection success scenario.
      *
      * @throws Exception if any error occurs.
      */
     @BeforeEach
-    public void setUp() throws Exception {
+    void setUp() throws Exception {
       var dataSource = new JdbcDataSource();
       dataSource.setURL(DB_URL);
       dao = new DbCustomerDao(dataSource);
@@ -191,7 +191,7 @@ class ConnectivityIssue {
      * @throws SQLException if any error occurs.
      */
     @BeforeEach
-    public void setUp() throws SQLException {
+    void setUp() throws SQLException {
       dao = new DbCustomerDao(mockedDatasource());
     }
 

flux/src/test/java/com/iluwatar/flux/action/ContentTest.java

@@ -34,7 +34,7 @@
  *
  * @author Jeroen Meulemeester
  */
-public class ContentTest {
+class ContentTest {
 
   @Test
   void testToString() {

flux/src/test/java/com/iluwatar/flux/action/MenuItemTest.java

@@ -34,7 +34,7 @@
  *
  * @author Jeroen Meulemeester
  */
-public class MenuItemTest {
+class MenuItemTest {
 
   @Test
   void testToString() {