Skip to content

Commit 6b9c69c

Browse files
Michael KlimushynPark Sung Min
Michael Klimushyn
authored and
Park Sung Min
committed
[infra] Ignore analyzer issues in CI (flutter#2271)
35e984f migrated some deprecated analyzer warnings to the newer alternatives. These created some failures in unrelated plugins based on the warnings being slightly different. Added `ignore`s for now to turn CI green again as soon as possible. The previous analysis options really should not be used and the majority of the patch was unrelated, so I prefer ignoring specific already failing cases to reverting in this case. Including an `analysis_options.yaml` file with deprecated analyzer rules causes analyzer failures in the including package, so that patch can't be landed in a way that prevents regressions without updated rules.
1 parent eb40431 commit 6b9c69c

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

packages/android_alarm_manager/lib/android_alarm_manager.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,10 @@ void _alarmManagerCallbackDispatcher() {
3939
exit(-1);
4040
}
4141

42+
// ignore: inference_failure_on_function_return_type
4243
if (closure is Function()) {
4344
closure();
45+
// ignore: inference_failure_on_function_return_type
4446
} else if (closure is Function(int)) {
4547
final int id = args[1];
4648
closure(id);
@@ -182,6 +184,7 @@ class AndroidAlarmManager {
182184
bool wakeup = false,
183185
bool rescheduleOnReboot = false,
184186
}) async {
187+
// ignore: inference_failure_on_function_return_type
185188
assert(callback is Function() || callback is Function(int));
186189
assert(id.bitLength < 32);
187190
final int startMillis = time.millisecondsSinceEpoch;
@@ -245,6 +248,7 @@ class AndroidAlarmManager {
245248
bool wakeup = false,
246249
bool rescheduleOnReboot = false,
247250
}) async {
251+
// ignore: inference_failure_on_function_return_type
248252
assert(callback is Function() || callback is Function(int));
249253
assert(id.bitLength < 32);
250254
final int now = DateTime.now().millisecondsSinceEpoch;

packages/camera/lib/camera.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ enum ResolutionPreset {
3838
max,
3939
}
4040

41+
// ignore: inference_failure_on_function_return_type
4142
typedef onLatestImageAvailable = Function(CameraImage image);
4243

4344
/// Returns the resolution preset as a String.

packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,10 @@ class GooglePlayConnection
186186
} on PlatformException catch (e) {
187187
exception = e;
188188
responses = [
189+
// ignore: invalid_use_of_visible_for_testing_member
189190
SkuDetailsResponseWrapper(
190191
responseCode: BillingResponse.error, skuDetailsList: []),
192+
// ignore: invalid_use_of_visible_for_testing_member
191193
SkuDetailsResponseWrapper(
192194
responseCode: BillingResponse.error, skuDetailsList: [])
193195
];

0 commit comments

Comments
 (0)