-
Notifications
You must be signed in to change notification settings - Fork 100
Server crashes when Cyrillic character is typed #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hey @VeryEvilHumna, would it be possible for you to provide an anonymised snippet of your change or maybe even a non-redacted version of the log files? I am currently not able to repro it. |
Did the same in another file with sample code, but in the same repo as before Anonymized file ------------- Meta -------------
-- name: GetValueFromMetaKVStore :one
SELECT value FROM meta_kv
WHERE key = $1;
-- name: SetValueToMetaKVStore :exec
INSERT INTO meta_kv (key, value)
VALUES ($1, $2)
ON CONFLICT (key) DO UPDATE
SET value = excluded.value; Full log:
|
tried to recreate the issue a few times and record it on a fresh vscode profile with default extension config, took longer than expected, but I've still been able to crash the server. Crash became surprisingly unstable for some reason, before I was able to recreate it with just one character, as seen in previous logs Screencast.From.2025-04-01.05-08-09.mp4Screencast.From.2025-04-01.05-11-45.mp4Logs from these recordings (and two that are too long and I decided not to upload them here):
edit: gramatics |
thanks! I was able to repro. will be fixed with the next release. |
Bug report
Describe the bug
I use postgrestools v1.1.4 extension in VSCode, IDK if I should've created the issue in postgrestools' for VSCode repo. But basically:
As soon as I type any character in a file that has Cyrillic characters or when I type a Cyrillic character in a file that has only ASCII characters, language server crashes with this log:
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
Expected behavior
Not to crash when Cyrillic character is typed
Screenshots
N/a
System information
$ postgrestools version
:Additional context
Full log from start to crash:
The text was updated successfully, but these errors were encountered: