Skip to content

Comments are marked as invalid if manually entered via keyboard but not if copied or autocompleted #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
Donnerstagnacht opened this issue Apr 15, 2025 · 4 comments · Fixed by #356
Closed
2 tasks done

Comments are marked as invalid if manually entered via keyboard but not if copied or autocompleted #343

Donnerstagnacht opened this issue Apr 15, 2025 · 4 comments · Fixed by #356
Assignees
@psteinroe
Labels
bug Something isn't working

Comments

@Donnerstagnacht
Copy link

Donnerstagnacht commented Apr 15, 2025 •
edited
Loading

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Comments are marked as invalid if manually entered via keyboard but not if they are entered via copy paste or autocompletion.

Image

To Reproduce

Type an inline comment

--
Type a letter after
-- t

If you copy paste a comment or complete an (AI) autocompletion, the error does not appear.

Image
  1. first line is copy paste keyboard shortcut
  2. second line is an AI autocompletion via a shift keyboard shortcut
  3. thrid line is typed via the keyboard

Expected behavior

In all cases the inline comment should be valid and not marked as invalid

System information

  • windows 11
  • cli-x86_64-windows-msvc
  • vs-code extension PostgresTools version 0.4.0.
@Donnerstagnacht Donnerstagnacht added the bug Something isn't working label Apr 15, 2025
@psteinroe
Copy link
Collaborator

I saw the same issue today too. Thanks for reporting. Will fix it!

@psteinroe psteinroe self-assigned this Apr 15, 2025
@psteinroe
Copy link
Collaborator

I actually cannot reproduce this on main. I think this was fixed by #337. will keep this open until the next release.

@Donnerstagnacht
Copy link
Author

Could it be that it only appears if a file starts with a comment?

Image

version: 0.5.0

@psteinroe
Copy link
Collaborator

Ah that's it, can repro! Will fix it over the next days. Thanks for reporting.

@psteinroe psteinroe mentioned this issue Apr 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psteinroe psteinroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly parse when there is no affected supabase-community/postgres-language-server
2 participants
@psteinroe @Donnerstagnacht