Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for (and maybe fix) transaction statements BEGIN;...COMMIT; #36

Closed
psteinroe opened this issue Sep 21, 2023 · 0 comments
Closed

add tests for (and maybe fix) transaction statements BEGIN;...COMMIT; #36

psteinroe opened this issue Sep 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@psteinroe
Copy link
Collaborator

Bug report

Describe the bug

I am not sure yet whether this is a bug, but we should add tests for transaction statements to see how they are parsed by lipg_query. They should be parsed as a single statement. We may have to adapt the source_parser regex for that.

Expected behavior

Transactions are beneath a single ast node, and a nested cst node.
@psteinroe psteinroe added the bug Something isn't working label Sep 21, 2023
@pert5432 pert5432 mentioned this issue Nov 11, 2023
Closed
@psteinroe psteinroe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add test for parsing BEGIN, ROLLBACK, COMMIT statements pert5432/postgres_lsp
1 participant
@psteinroe