-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add snapshots test back to parser
#82
Comments
Yeah, I was exactly thinking about this, having |
ohh thats a great idea! we can just copy the sql files, or add the entire postgres repo as a submodule to keep it up-to-date. wdyt? |
I was planning at first to pull the sql files with a tiny script and later add it as a submodule when progress has been made |
@cvng can you open a separate issue for pulling in the regression tests? |
@psteinroe sure, I already had a few PRs stacked for #51, so I will proceed to pull the postgres tests once those are merged EDIT: also, should we somehow consolidate parser e2e & unit tests? eg. add |
the |
Planned Work
We already had it in place but dropped it because it's unnecessary now that the parser panics on invalid statements. but turns out it's actually quite useful when reviewing pull requests for #51. we should add it back using
insta
as before. we should be able to simply copy it from the git history of thestatement_parser_test
file.The text was updated successfully, but these errors were encountered: