Skip to content

Commit 2fc29b2

Browse files
authored
fix: interpolations erros and other things reported by sourcery-ai (#37)
1 parent b1423b5 commit 2fc29b2

File tree

9 files changed

+42
-29
lines changed

9 files changed

+42
-29
lines changed

CODE_OF_CONDUCT.md

+10-12
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@ appearance, race, religion, or sexual identity and orientation.
1414
Examples of behavior that contributes to creating a positive environment
1515
include:
1616

17-
* Using welcoming and inclusive language
18-
* Being respectful of differing viewpoints and experiences
19-
* Gracefully accepting constructive criticism
20-
* Focusing on what is best for the community
21-
* Showing empathy towards other community members
17+
- Using welcoming and inclusive language
18+
- Being respectful of differing viewpoints and experiences
19+
- Gracefully accepting constructive criticism
20+
- Focusing on what is best for the community
21+
- Showing empathy towards other community members
2222

2323
Examples of unacceptable behavior by participants include:
2424

25-
* The use of sexualized language or imagery and unwelcome sexual attention or
25+
- The use of sexualized language or imagery and unwelcome sexual attention or
2626
advances
27-
* Trolling, insulting/derogatory comments, and personal or political attacks
28-
* Public or private harassment
29-
* Publishing others' private information, such as a physical or electronic
27+
- Trolling, insulting/derogatory comments, and personal or political attacks
28+
- Public or private harassment
29+
- Publishing others' private information, such as a physical or electronic
3030
address, without explicit permission
31-
* Other conduct which could reasonably be considered inappropriate in a
31+
- Other conduct which could reasonably be considered inappropriate in a
3232
professional setting
3333

3434
## Our Responsibilities
@@ -74,5 +74,3 @@ available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.ht
7474

7575
For answers to common questions about this code of conduct, see
7676
https://www.contributor-covenant.org/faq
77-
78-

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ When making pull requests to the repository, make sure to follow these guideline
2929
- In your PR's description, link to any related issues or pull requests to give reviewers the full context of your change.
3030
- For commit messages, follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) format.
3131
- For example, if you update documentation for a specific extension, your commit message might be: `docs(extension-name) updated installation documentation`.
32-
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
32+
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md

Makefile

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
install: install_poetry
2+
poetry install
3+
4+
install_poetry:
5+
curl -sSL https://install.python-poetry.org | python -
6+
7+
precommit: install
8+
poetry run pre-commit run --all-files
9+
10+
tests: install
11+
poetry run pytest --cov=./ --cov-report=xml -vv
12+
13+
build: install
14+
poetry run unasync postgrest_py tests
15+
16+
clean:
17+
sudo rm -r .venv

postgrest_py/_async/client.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -76,5 +76,4 @@ def from_table(self, table: str) -> AsyncRequestBuilder:
7676
async def rpc(self, func: str, params: dict) -> Response:
7777
"""Perform a stored procedure call."""
7878
path = f"/rpc/{func}"
79-
r = await self.session.post(path, json=params)
80-
return r
79+
return await self.session.post(path, json=params)

postgrest_py/_async/request_builder.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -144,17 +144,17 @@ def in_(self, column: str, values: Iterable[str]):
144144
def cs(self, column: str, values: Iterable[str]):
145145
values = map(sanitize_param, values)
146146
values = ",".join(values)
147-
return self.filter(column, "cs", f"{{values}}")
147+
return self.filter(column, "cs", f"{{{values}}}")
148148

149149
def cd(self, column: str, values: Iterable[str]):
150150
values = map(sanitize_param, values)
151151
values = ",".join(values)
152-
return self.filter(column, "cd", f"{{values}}")
152+
return self.filter(column, "cd", f"{{{values}}}")
153153

154154
def ov(self, column: str, values: Iterable[str]):
155155
values = map(sanitize_param, values)
156156
values = ",".join(values)
157-
return self.filter(column, "ov", f"{{values}}")
157+
return self.filter(column, "ov", f"{{{values}}}")
158158

159159
def sl(self, column: str, range: Tuple[int, int]):
160160
return self.filter(column, "sl", f"({range[0]},{range[1]})")
@@ -173,7 +173,7 @@ def adj(self, column: str, range: Tuple[int, int]):
173173

174174
def match(self, query: Dict[str, Any]):
175175
updated_query = None
176-
for key in query.keys():
176+
for key in query:
177177
value = query.get(key, "")
178178
updated_query = self.eq(key, value)
179179
return updated_query

postgrest_py/_sync/client.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -76,5 +76,4 @@ def from_table(self, table: str) -> SyncRequestBuilder:
7676
def rpc(self, func: str, params: dict) -> Response:
7777
"""Perform a stored procedure call."""
7878
path = f"/rpc/{func}"
79-
r = self.session.post(path, json=params)
80-
return r
79+
return self.session.post(path, json=params)

postgrest_py/_sync/request_builder.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -144,17 +144,17 @@ def in_(self, column: str, values: Iterable[str]):
144144
def cs(self, column: str, values: Iterable[str]):
145145
values = map(sanitize_param, values)
146146
values = ",".join(values)
147-
return self.filter(column, "cs", f"{{values}}")
147+
return self.filter(column, "cs", f"{{{values}}}")
148148

149149
def cd(self, column: str, values: Iterable[str]):
150150
values = map(sanitize_param, values)
151151
values = ",".join(values)
152-
return self.filter(column, "cd", f"{{values}}")
152+
return self.filter(column, "cd", f"{{{values}}}")
153153

154154
def ov(self, column: str, values: Iterable[str]):
155155
values = map(sanitize_param, values)
156156
values = ",".join(values)
157-
return self.filter(column, "ov", f"{{values}}")
157+
return self.filter(column, "ov", f"{{{values}}}")
158158

159159
def sl(self, column: str, range: Tuple[int, int]):
160160
return self.filter(column, "sl", f"({range[0]},{range[1]})")
@@ -173,7 +173,7 @@ def adj(self, column: str, range: Tuple[int, int]):
173173

174174
def match(self, query: Dict[str, Any]):
175175
updated_query = None
176-
for key in query.keys():
176+
for key in query:
177177
value = query.get(key, "")
178178
updated_query = self.eq(key, value)
179179
return updated_query

tests/_async/test_request_builder.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ def test_select(self, request_builder: AsyncRequestBuilder):
1919
builder = request_builder.select("col1", "col2")
2020

2121
assert builder.session.params["select"] == "col1,col2"
22-
assert builder.session.headers.get("prefer") == None
22+
assert builder.session.headers.get("prefer") is None
2323
assert builder.http_method == "GET"
2424
assert builder.json == {}
2525

2626
def test_select_with_count(self, request_builder: AsyncRequestBuilder):
2727
builder = request_builder.select(count="exact")
2828

29-
assert builder.session.params.get("select") == None
29+
assert builder.session.params.get("select") is None
3030
assert builder.session.headers["prefer"] == "count=exact"
3131
assert builder.http_method == "HEAD"
3232
assert builder.json == {}

tests/_sync/test_request_builder.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ def test_select(self, request_builder: SyncRequestBuilder):
1919
builder = request_builder.select("col1", "col2")
2020

2121
assert builder.session.params["select"] == "col1,col2"
22-
assert builder.session.headers.get("prefer") == None
22+
assert builder.session.headers.get("prefer") is None
2323
assert builder.http_method == "GET"
2424
assert builder.json == {}
2525

2626
def test_select_with_count(self, request_builder: SyncRequestBuilder):
2727
builder = request_builder.select(count="exact")
2828

29-
assert builder.session.params.get("select") == None
29+
assert builder.session.params.get("select") is None
3030
assert builder.session.headers["prefer"] == "count=exact"
3131
assert builder.http_method == "HEAD"
3232
assert builder.json == {}

0 commit comments

Comments
 (0)