chore: deprecate StorageClient.StorageFileAPI

As the commit message says, we deprecate this method in favour of
StorageClient.from_. This method name now conforms to PEP8.

Author: anand2312

Diff for: supabase/client.py

@@ -1,11 +1,10 @@
 from typing import Any, Dict
 
 from postgrest import SyncFilterRequestBuilder, SyncPostgrestClient, SyncRequestBuilder
-from storage3 import SyncStorageClient
-from storage3 import create_client as create_storage_client
 
-from supabase.lib.auth_client import SupabaseAuthClient
-from supabase.lib.client_options import ClientOptions
+from .lib.auth_client import SupabaseAuthClient
+from .lib.client_options import ClientOptions
+from .lib.storage_client import SupabaseStorageClient
 
 
 class Client:
@@ -61,11 +60,9 @@ def __init__(
             headers=options.headers,
         )
 
-    def storage(self) -> SyncStorageClient:
+    def storage(self) -> SupabaseStorageClient:
         """Create instance of the storage client"""
-        return create_storage_client(
-            self.storage_url, self._get_auth_headers(), is_async=False
-        )
+        return SupabaseStorageClient(self.storage_url, self._get_auth_headers())
 
     def table(self, table_name: str) -> SyncRequestBuilder:
         """Perform a table operation.

Diff for: supabase/lib/storage_client.py

@@ -0,0 +1,11 @@
+from deprecation import deprecated
+from storage3 import SyncStorageClient
+from storage3._sync.file_api import SyncBucketProxy
+
+
+class SupabaseStorageClient(SyncStorageClient):
+    """Manage storage buckets and files."""
+
+    @deprecated("0.5.4", "0.6.0", details="Use `.from_()` instead")
+    def StorageFileAPI(self, id_: str) -> SyncBucketProxy:
+        return super().from_(id_)