Skip to content

fix: use requests for upload #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2022
Merged

fix: use requests for upload #121

merged 3 commits into from
Jan 17, 2022

Conversation

leynier
Copy link
Contributor

@leynier leynier commented Jan 17, 2022

No description provided.

@leynier leynier added the bug Something isn't working label Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #121 (daa73c2) into develop (4b2a181) will increase coverage by 0.49%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
+ Coverage    51.55%   52.05%   +0.49%     
===========================================
  Files            9        9              
  Lines          289      292       +3     
===========================================
+ Hits           149      152       +3     
  Misses         140      140              
Impacted Files Coverage Δ
supabase/lib/storage/storage_file_api.py 20.45% <33.33%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2a181...daa73c2. Read the comment docs.

…ests-for-upload

fix: use requests for upload (Sourcery refactored)
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 17, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.35%.

Quality metrics Before After Change
Complexity 2.89 ⭐ 2.94 ⭐ 0.05 👎
Method Length 47.10 ⭐ 48.20 ⭐ 1.10 👎
Working memory 6.97 🙂 6.95 🙂 -0.02 👍
Quality 78.59% 78.24% -0.35% 👎
Other metrics Before After Change
Lines 181 186 5
Changed files Quality Before Quality After Quality Change
supabase/lib/storage/storage_file_api.py 78.59% ⭐ 78.24% ⭐ -0.35% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leynier leynier merged commit ed99717 into develop Jan 17, 2022
@leynier leynier deleted the fix/use-requests-for-upload branch January 17, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants