Skip to content

Commit 9ecb985

Browse files
authored
Merge pull request #155 from supabase/fix/quoting
fix: remove quoting of names
2 parents eacc4f7 + fb0b82c commit 9ecb985

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: src/lib/PostgrestFilterBuilder.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import PostgrestTransformBuilder from './PostgrestTransformBuilder'
44
* Filters
55
*/
66

7-
const cleanFilterArray = <T>(filter: T[keyof T][]) => filter.map((s) => `"${s}"`).join(',')
7+
const cleanFilterArray = <T>(filter: T[keyof T][]) => filter.map((s) => `${s}`).join(',')
88

99
type FilterOperator =
1010
| 'eq'

Diff for: src/lib/PostgrestTransformBuilder.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
4545
foreignTable,
4646
}: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}
4747
): this {
48-
const key = typeof foreignTable === 'undefined' ? 'order' : `"${foreignTable}".order`
48+
const key = typeof foreignTable === 'undefined' ? 'order' : `${foreignTable}.order`
4949
this.url.searchParams.set(
5050
key,
5151
`${column}.${ascending ? 'asc' : 'desc'}.${nullsFirst ? 'nullsfirst' : 'nullslast'}`
@@ -60,7 +60,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
6060
* @param foreignTable The foreign table to use (for foreign columns).
6161
*/
6262
limit(count: number, { foreignTable }: { foreignTable?: string } = {}): this {
63-
const key = typeof foreignTable === 'undefined' ? 'limit' : `"${foreignTable}".limit`
63+
const key = typeof foreignTable === 'undefined' ? 'limit' : `${foreignTable}.limit`
6464
this.url.searchParams.set(key, `${count}`)
6565
return this
6666
}
@@ -73,8 +73,8 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
7373
* @param foreignTable The foreign table to use (for foreign columns).
7474
*/
7575
range(from: number, to: number, { foreignTable }: { foreignTable?: string } = {}): this {
76-
const keyOffset = typeof foreignTable === 'undefined' ? 'offset' : `"${foreignTable}".offset`
77-
const keyLimit = typeof foreignTable === 'undefined' ? 'limit' : `"${foreignTable}".limit`
76+
const keyOffset = typeof foreignTable === 'undefined' ? 'offset' : `${foreignTable}.offset`
77+
const keyLimit = typeof foreignTable === 'undefined' ? 'limit' : `${foreignTable}.limit`
7878
this.url.searchParams.set(keyOffset, `${from}`)
7979
// Range is inclusive, so add 1
8080
this.url.searchParams.set(keyLimit, `${to - from + 1}`)

0 commit comments

Comments
 (0)