Skip to content

Node v10 compatibility #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffposnick opened this issue Oct 21, 2021 · 0 comments · Fixed by #50
Closed

Node v10 compatibility #49

jeffposnick opened this issue Oct 21, 2021 · 0 comments · Fixed by #50

Comments

@jeffposnick
Copy link
Contributor

jeffposnick commented Oct 21, 2021

v2.x of this module fixed a security vulnerability by updating its ejs dependency. It also started using String.prototype.matchAll(), which isn't compatible with Node v10:

for (const match of code.matchAll(workerRegexpForTransform)) {

I'm not sure if this was intentional or not, as there's no minimum support Node engine version listed in your package.json, and I can't find any release notes for v2.x of this module.

The Workbox project would like to update its dependency on this module, but we need to continue support Node v10 until our next major release version.

Would you be open to a PR that swapped out matchAll() for the equivalent, so that a version of this module with the updated ejs dependency could be used with Node v10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant