Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse pages and panels on drag start for questions and panels dragging (option) #5758

Open
novikov82 opened this issue Aug 7, 2024 · 4 comments · May be fixed by #6799
Open

Collapse pages and panels on drag start for questions and panels dragging (option) #5758

novikov82 opened this issue Aug 7, 2024 · 4 comments · May be fixed by #6799
Assignees

Comments

@novikov82
Copy link
Contributor

No description provided.

@novikov82 novikov82 self-assigned this Aug 7, 2024
novikov82 added a commit that referenced this issue Aug 12, 2024
novikov82 added a commit that referenced this issue Aug 15, 2024
@tsv2013 tsv2013 added the v2.0+ label Oct 9, 2024
@tsv2013 tsv2013 changed the title Collapse pages and panels on drag start (option) Collapse pages and panels on drag start for questions and panels dragging (option) Oct 9, 2024
@tsv2013
Copy link
Member

tsv2013 commented Oct 9, 2024

We haven't found a good and easy end-user solution for this and decided to postpone this task

@JaneSjs JaneSjs assigned novikov82 and unassigned novikov82 Dec 25, 2024
@JaneSjs JaneSjs removed the v2.0 label Dec 25, 2024
@tsv2013
Copy link
Member

tsv2013 commented Jan 30, 2025

Left this open to fine tune the solution implemented in #6450

@mikeamelin
Copy link

mikeamelin commented Feb 3, 2025

Notes.

When a user grabs the question, everything collapses — pages, panels, questions, except for the container (page or panel) where the question is located. Then the user drags the question, reaches the next page — the page expands. Inside the page, everything is still collapsed. The user drags it for example to a panel — the panel expands. Inside the panel, all the questions are still collapsed. The user easily finds a place among the compact collapsed questions. Drops it, and only then everything expands.

No collapse if everything is visible -> Start to drag in the moment when surface starts scrolling -> Option

Apply a new collapsed view for elements.

Image

@tsv2013
Copy link
Member

tsv2013 commented Mar 26, 2025

Comments from

@ElenaGorbatkova here you have pages with a bunch of questions, you stand on one of them and start pulling, the page remains open, other questions collapse so that he can see where he is pulling and does not get stuck. If the question is in the panel and he is pulling from the panel, then the panel collapses only at the moment when the element is taken from it

@andrewtelnov we need to check the current state of visible/expanded/collapsed questions on drag start and make smart decision - what we need to collapse and whether we need to collaspe something

@dmitry-kurmanov wants to be one of reviewers

@mikeamelin make collapse on drag optional by keyboard shortcut - e.g. turn collapsing on only if user started drag with "Alt" (or another) key pressed

@tsv2013 tsv2013 removed the v2.0+ label Mar 27, 2025
tsv2013 pushed a commit that referenced this issue Apr 1, 2025
tsv2013 pushed a commit that referenced this issue Apr 9, 2025
tsv2013 pushed a commit that referenced this issue Apr 10, 2025
…ging (option)

Fixes #5758 - try to keep currently dragged element vertical position on start drag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants