Skip to content

Support Svelte 5 in valid-prop-names-in-kit-pages #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lishaduck opened this issue Jan 27, 2025 · 1 comment · Fixed by #1048
Closed

Support Svelte 5 in valid-prop-names-in-kit-pages #1045

lishaduck opened this issue Jan 27, 2025 · 1 comment · Fixed by #1048
Labels
enhancement New feature or request

Comments

@lishaduck
Copy link

Description

Layouts in Svelte 5 use a children prop, which valid-prop-names-in-kit-pages (newly added to the recommended set in 3.0.0-next.16) flags

(No, this isn't really a feature request, but it's not quite a bug either.)
@lishaduck lishaduck added the enhancement New feature or request label Jan 27, 2025
@baseballyama
Copy link
Member

baseballyama commented Jan 27, 2025 •
edited
Loading

I think I already supported Svelte5. Could you provide REPL?
-> I got it.

@baseballyama baseballyama added needs repro Need a repository that can reproduce the problem and removed needs repro Need a repository that can reproduce the problem labels Jan 27, 2025
@baseballyama baseballyama mentioned this issue Feb 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow children in valid-prop-names-in-kit-pages rule sveltejs/eslint-plugin-svelte
2 participants
@baseballyama @lishaduck