Skip to content

Commit 460d452

Browse files
fix: exclude server files from optimizeDeps.entries (#12242)
* exclude server files from optimizeDeps.entries * fix glob to exclude +server.js and fix tests * changeset * Revert "fix glob to exclude +server.js and fix tests" This reverts commit c778f78. * review suggestions * remove dot * Update index.js --------- Co-authored-by: Simon H <[email protected]>
1 parent 119bff9 commit 460d452

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

.changeset/flat-hairs-love.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@sveltejs/kit": patch
3+
---
4+
5+
fix: exclude server files from optimizeDeps.entries

packages/kit/src/exports/vite/index.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,10 @@ async function kit({ svelte_config }) {
293293
cors: { preflightContinue: true }
294294
},
295295
optimizeDeps: {
296-
entries: [`${kit.files.routes}/**/+*.{svelte,js,ts}`],
296+
entries: [
297+
`${kit.files.routes}/**/+*.{svelte,js,ts}`,
298+
`!${kit.files.routes}/**/+*server.*`
299+
],
297300
exclude: [
298301
'@sveltejs/kit',
299302
// exclude kit features so that libraries using them work even when they are prebundled

packages/kit/test/apps/dev-only/test/test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -107,14 +107,14 @@ test.describe('Vite', () => {
107107
expect(manifest).toHaveProperty('optimized.e2e-test-dep-page-universal');
108108
});
109109

110-
test('optimizes +page.server.js dependencies', async ({ page }) => {
110+
test('skips optimizing +page.server.js dependencies', async ({ page }) => {
111111
await page.goto('/');
112112
await page.getByText('hello world!').waitFor();
113113

114114
const manifest_path = path.join(__dirname, '../node_modules/.vite/deps/_metadata.json');
115115
const manifest = JSON.parse(fs.readFileSync(manifest_path, 'utf-8'));
116116

117-
expect(manifest).toHaveProperty('optimized.e2e-test-dep-page-server');
117+
expect(manifest).not.toHaveProperty('optimized.e2e-test-dep-page-server');
118118
});
119119

120120
test('optimizes +layout.svelte dependencies', async ({ page }) => {
@@ -137,14 +137,14 @@ test.describe('Vite', () => {
137137
expect(manifest).toHaveProperty('optimized.e2e-test-dep-layout-universal');
138138
});
139139

140-
test('optimizes +layout.server.js dependencies', async ({ page }) => {
140+
test('skips optimizing +layout.server.js dependencies', async ({ page }) => {
141141
await page.goto('/');
142142
await page.getByText('hello world!').waitFor();
143143

144144
const manifest_path = path.join(__dirname, '../node_modules/.vite/deps/_metadata.json');
145145
const manifest = JSON.parse(fs.readFileSync(manifest_path, 'utf-8'));
146146

147-
expect(manifest).toHaveProperty('optimized.e2e-test-dep-layout-server');
147+
expect(manifest).not.toHaveProperty('optimized.e2e-test-dep-layout-server');
148148
});
149149

150150
test('optimizes +error.svelte dependencies', async ({ page }) => {

0 commit comments

Comments
 (0)