fix(adapter-node): only send cache header when static resource is 200 (#9394)

cdemi · benmccann · web-flow · commit e3a336b4c226 · 2023-03-15T09:28:43.000+01:00
fixes #9393 --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
diff --git a/.changeset/khaki-schools-invent.md b/.changeset/khaki-schools-invent.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/adapter-node': patch
+---
+
+fix: only send cache header when static resource is 200
diff --git a/packages/adapter-node/src/handler.js b/packages/adapter-node/src/handler.js
@@ -37,7 +37,7 @@ function serve(path, client = false) {
 				client &&
 				((res, pathname) => {
 					// only apply to build directory, not e.g. version.json
-					if (pathname.startsWith(`/${manifest.appPath}/immutable/`)) {
+					if (pathname.startsWith(`/${manifest.appPath}/immutable/`) && res.statusCode === 200) {
 						res.setHeader('cache-control', 'public,max-age=31536000,immutable');
 					}
 				})

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ function serve(path, client = false) {`
`37`	`37`	`client &&`
`38`	`38`	`((res, pathname) => {`
`39`	`39`	`// only apply to build directory, not e.g. version.json`
`40`		- if (pathname.startsWith(`/${manifest.appPath}/immutable/`)) {
	`40`	+ if (pathname.startsWith(`/${manifest.appPath}/immutable/`) && res.statusCode === 200) {
`41`	`41`	`res.setHeader('cache-control', 'public,max-age=31536000,immutable');`
`42`	`42`	`}`
`43`	`43`	`})`