Skip to content

Commit ff2ca89

Browse files
feat: adapter-static throws buildtime error when !config.kit.prerender.default && !adapter.fallback (#5562)
* feat: adapter-static errors with incorrect config * changeset * fix: Update caught incorrectly configured test project * rename disabled test to fallback * Update packages/adapter-static/index.js * lockfile Co-authored-by: Rich Harris <[email protected]>
1 parent 2e9d8fb commit ff2ca89

File tree

10 files changed

+9
-4
lines changed

10 files changed

+9
-4
lines changed

.changeset/eleven-buckets-deny.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/adapter-static': patch
3+
---
4+
5+
[breaking] Throws when correctly configured to run as a static site of a SPA

packages/adapter-static/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ export default function (options) {
1414

1515
async adapt(builder) {
1616
if (!options?.fallback && !builder.config.kit.prerender.default) {
17-
builder.log.warn(
18-
'You should set `config.kit.prerender.default` to `true` if no fallback is specified'
17+
throw Error(
18+
'adapter-static requires `config.kit.prerender.default` to be `true` unless you set the `fallback: true` option to create a single-page app. See https://github.com/sveltejs/kit/tree/master/packages/adapter-static#spa-mode for more information'
1919
);
2020
}
2121

packages/kit/test/prerendering/disabled/svelte.config.js renamed to packages/kit/test/prerendering/fallback/svelte.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import adapter from '../../../../adapter-static/index.js';
33
/** @type {import('@sveltejs/kit').Config} */
44
const config = {
55
kit: {
6-
adapter: adapter(),
6+
adapter: adapter({ fallback: '200.html' }),
77

88
prerender: {
99
enabled: false

pnpm-lock.yaml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)