Skip to content

Unclear whether adapter-vercel has any benefits over adapter-auto #9334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
efstajas opened this issue Mar 6, 2023 · 2 comments · Fixed by #9344
Closed

Unclear whether adapter-vercel has any benefits over adapter-auto #9334

efstajas opened this issue Mar 6, 2023 · 2 comments · Fixed by #9344
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@efstajas
Copy link

efstajas commented Mar 6, 2023

Describe the bug

This is not a bug really, more like a small inconsistency that is a little confusing.

When you deploy on Vercel using adapter-auto, something (assuming adapter-vercel) prints the following line during build:

If you plan on staying on this deployment platform, consider replacing @sveltejs/adapter-auto with @sveltejs/adapter-vercel. This will give you faster and more robust installs, and more control over deployment configuration.

Prompted by this, I went to check out adapter-vercel, but the first and only thing written in the readme is:

If you're using adapter-auto, you don't need to install this unless you need to specify Vercel-specific options, since it's already included.

So, the build log reads like there's some benefit to explicitly using adapter-vercel beyond extra configuration, but the adapter's README makes it sound like it won't make a difference at all. Wondering which one is true.

Reproduction

  • Publish any sveltekit app using adapter-auto on Vercel, and observe the build log including the quoted line.
  • Observe adapter-vercel's README including a seemingly contradictory statement.

Logs

No response

System Info

N/A

Severity

annoyance

Additional Information

No response

@dummdidumm dummdidumm added the documentation Improvements or additions to documentation label Mar 6, 2023
@dummdidumm
Copy link
Member

The prompt is more correct. If you plan to stay on a specific platform, install the adapter for that specific platform.

@dummdidumm dummdidumm added this to the soon milestone Mar 6, 2023
@efstajas
Copy link
Author

efstajas commented Mar 6, 2023

Alright, thanks for the confirmation! Doing that, then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants