fix handling of empty hrefs during export (#602)

Conduitry · Conduitry · commit 6d5aa9a35dd9 · 2019-03-11T10:39:35.000-04:00
diff --git a/src/api/export.ts b/src/api/export.ts
@@ -212,6 +212,6 @@ async function _export({
 }
 
 function get_href(attrs: string) {
-	const match = /href\s*=\s*(?:"(.*?)"|'(.+?)'|([^\s>]+))/.exec(attrs);
-	return match[1] || match[2] || match[3];
+	const match = /href\s*=\s*(?:"(.*?)"|'(.*?)'|([^\s>]*))/.exec(attrs);
+	return match && (match[1] || match[2] || match[3]);
 }
diff --git a/test/apps/export/src/routes/index.svelte b/test/apps/export/src/routes/index.svelte
@@ -1,4 +1,9 @@
 <h1>Great success!</h1>
 
 <a href="blog">blog</a>
-<a href="">empty anchor</a>
+<a href="">empty anchor</a>
+<a href=''>empty anchor #2</a>
+<a href=>empty anchor #3</a>
+<a href= >empty anchor #4</a>
+<a href>empty anchor #5</a>
+<a>empty anchor #6</a>

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,6 @@ async function _export({`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`function get_href(attrs: string) {`
`215`		`- const match = /href\s=\s(?:"(.*?)"\|'(.+?)'\|([^\s>]+))/.exec(attrs);`
`216`		`- return match[1] \|\| match[2] \|\| match[3];`
	`215`	`+ const match = /href\s=\s(?:"(.?)"\|'(.?)'\|([^\s>]*))/.exec(attrs);`
	`216`	`+ return match && (match[1] \|\| match[2] \|\| match[3]);`
`217`	`217`	`}`