Allow export to succeed when user has not provided base tag (#1208)

jamesjnadeau · thgh · web-flow · commit ab2e256608cc · 2021-03-25T19:28:41.000-07:00
Co-authored-by: Thomas Ghysels &lt;info@thomasg.be&gt;
diff --git a/src/api/export.ts b/src/api/export.ts
@@ -237,7 +237,7 @@ async function _export({
 				const cleaned = clean_html(body as string);
 
 				const base_match = /<base ([\s\S]+?)>/m.exec(cleaned);
-				const base_href = base_match && get_href(base_match[1]);
+				const base_href = base_match ? get_href(base_match[1]) : path.dirname(url.pathname);
 				const base = resolve(url.href, base_href);
 
 				let match;
diff --git a/test/apps/export/src/routes/index.svelte b/test/apps/export/src/routes/index.svelte
@@ -17,4 +17,5 @@
 <!-- svelte-ignore a11y-missing-attribute -->
 <a>empty anchor #6</a>
 <a href="boom">boom</a>
+<a href="test.html">html file</a>
 <a href="test.pdf">pdf file</a>
diff --git a/test/apps/export/static/test.html b/test/apps/export/static/test.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+
+<head>
+    <title>Page Title</title>
+</head>
+
+<body>
+    <h1>Test Heading</h1>
+    <p>Test Paragraph.</p>
+</body>
+
+</html> 
diff --git a/test/apps/export/test.ts b/test/apps/export/test.ts
@@ -41,6 +41,7 @@ describe('export', function() {
 			'index.html',
 			'service-worker-index.html',
 			'service-worker.js',
+			'test.html',
 			'test.pdf',
 			'img/example-192.png',
 			'img/example-512.png',
