Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Sapper Export with basepath results in writing outside the build directory. #1164

Closed
antony opened this issue Apr 20, 2020 · 1 comment
Closed
Labels

Comments

@antony
Copy link
Member

antony commented Apr 20, 2020

Describe the bug
An extension of #502

To Reproduce
[ ] Run export with a basepath with a leading slash

An export directory is created in the root of your project, rather than __sapper__/export. Whilst this is preferable to the original behaviour in #502 - it's still wrong, and could cause chaos.

Expected behavior
Running export with basepath with a leading slash should build your exported app at __sapper__/export/<basepath>.

Severity
Not super serious, but could cause unwanted side-effects, especially if your basepath was src or something equally silly.

@antony antony changed the title Sapper Export behaviour Sapper Export with basedir results in writing outside the build directory. Apr 20, 2020
@antony antony changed the title Sapper Export with basedir results in writing outside the build directory. Sapper Export with basepath results in writing outside the build directory. Apr 20, 2020
@antony antony added the bug label Apr 20, 2020
@antony
Copy link
Member Author

antony commented Apr 20, 2020

After a lot of investigation, this appears to have been a nuance of the way that a third party had set up a template, and I'm unable to recreate it with a new project.

@antony antony closed this as completed Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant