Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Fix status code for requesting /client #1734

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Conversation

hillar
Copy link
Contributor

@hillar hillar commented Mar 2, 2021

Fixes #1733

if client is requesting path, what is not filename, but directory name, then it is not server internal error, it is just simple resource not found

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

if client is requesting path, what is not filename, but directory name, then it is not server internal error, it is just simple resource not found
@benmccann benmccann changed the title Fix #1733 Fix status code for requesting /client Mar 10, 2021
@benmccann benmccann merged commit d1a82fa into sveltejs:master Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting /client/ as directory is not internal server error (500), it is just simple not found (404)
2 participants