Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Server fetch doesn't use same-origin by default #881

Closed
cyderize opened this issue Sep 9, 2019 · 1 comment · Fixed by #882
Closed

Server fetch doesn't use same-origin by default #881

cyderize opened this issue Sep 9, 2019 · 1 comment · Fixed by #882

Comments

@cyderize
Copy link
Contributor

cyderize commented Sep 9, 2019

I noticed while poking around the server middleware that when fetching, Sapper doesn't seem to send any credentials by default (i.e. credentials: 'omit'). Since whatwg/fetch#585, however, the default in browsers is to have credentials: 'same-origin'.

Is there a reason why this is the case, or should this be changed to be consistent with what browsers now do?
@cyderize cyderize mentioned this issue Sep 9, 2019
Merged
@cyderize cyderize changed the title Fetch doesn't use same-origin by default Server fetch doesn't use same-origin by default Sep 12, 2019
@antony antony added the has pr label Feb 3, 2020
@benmccann benmccann mentioned this issue May 14, 2020
Open
@Conduitry Conduitry mentioned this issue Jun 1, 2020
Closed
@Conduitry
Copy link
Member

Fixed in 0.27.14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix server fetch behaviour cyderize/sapper
3 participants
@antony @cyderize @Conduitry