fix: remove preprocessor-specific attributes

- global for style tags
- src for script/style tags

fixes #652

Author: dummdidumm

docs/preprocessing.md

@@ -123,8 +123,9 @@ export default {
         /** Add a custom language preprocessor */
         potatoLanguage({ content, filename, attributes }) {
           const { code, map } = require('potato-language').render(content);
+          const { src, ...cleanedAttributes } = attributes;
 
-          return { code, map };
+          return { code, map, attributes: cleanedAttributes };
         },
       }),
     }),

src/modules/tagInfo.ts

@@ -67,3 +67,8 @@ export const getTagInfo = async ({
     markup,
   };
 };
+
+export const removeSrcAttribute = (attributes: Record<string, any>) => {
+  const { src, ...rest } = attributes;
+  return rest;
+};

src/processors/babel.ts

@@ -1,5 +1,5 @@
 import { concat } from '../modules/utils';
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { prepareContent } from '../modules/prepareContent';
 
 import type { PreprocessorGroup, Options } from '../types';
@@ -22,6 +22,7 @@ const babel = (options?: Options.Babel): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/coffeescript.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -32,6 +32,7 @@ const coffeescript = (options?: Options.Coffeescript): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/less.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -25,6 +25,7 @@ const less = (options?: Options.Less): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/postcss.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -23,6 +23,7 @@ const postcss = (options?: Options.Postcss): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/scss.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -33,6 +33,7 @@ const scss = (options?: Options.Sass): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/stylus.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -31,6 +31,7 @@ const stylus = (options?: Options.Stylus): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/processors/typescript.ts

@@ -1,4 +1,4 @@
-import { getTagInfo } from '../modules/tagInfo';
+import { getTagInfo, removeSrcAttribute } from '../modules/tagInfo';
 import { concat } from '../modules/utils';
 import { prepareContent } from '../modules/prepareContent';
 
@@ -26,6 +26,7 @@ const typescript = (options?: Options.Typescript): PreprocessorGroup => ({
 
     return {
       ...transformed,
+      attributes: removeSrcAttribute(transformed.attributes || attributes),
       dependencies: concat(dependencies, transformed.dependencies),
     };
   },

src/transformers/globalStyle.ts

@@ -83,7 +83,19 @@ const transformer: Transformer<Options.GlobalStyle> = async ({
     map: options?.sourceMap ? { prev: map } : false,
   });
 
-  return { code: css, map: newMap };
+  return {
+    code: css,
+    map: newMap,
+    attributes:
+      attributes &&
+      Object.keys(attributes).reduce((acc: any, key) => {
+        if (key !== 'global') {
+          acc[key] = attributes[key];
+        }
+
+        return acc;
+      }, {}),
+  };
 };
 
 export { transformer };

test/processors/babel.test.ts

@@ -23,7 +23,7 @@ describe(`processor - babel`, () => {
     ]);
 
     expect(preprocessed.toString?.()).toMatchInlineSnapshot(`
-      "<script src="./fixtures/script.babel.js">export var hello = {};
+      "<script>export var hello = {};
       export var world = hello == null ? void 0 : hello.value;</script><div></div>"
     `);
   });