(feat) support preserveValueImports introduced in TS 4.5 #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new flag keeps imports as is, essentially functioning the same as the import transformer.
bluwy
approved these changes
Nov 22, 2021
kaisermann
reviewed
Nov 23, 2021
kaisermann
approved these changes
Nov 23, 2021
|
@dummdidumm LGTM, but I'm a bit out of context and busy with moving to another country, sorry for taking some days to check this! This is possible due to TS 4.5, right? |
|
Correct. TS 4.5 introduced the new setting |
kaisermann
reviewed
Dec 13, 2021
| @@ -87,7 +87,7 @@ | |||
| "sugarss": "^2.0.0", | |||
| "svelte": "^3.42.0", | |||
| "ts-jest": "^25.1.0", | |||
| "typescript": "^4.4.2" | |||
| "typescript": "^4.5.2" | |||
There was a problem hiding this comment.
Quick question: (when) have we removed the support for v3? 🤔
There was a problem hiding this comment.
never, these are the dev dependencies, not the peer dependencies.
kaisermann
added a commit
that referenced
this pull request
Dec 13, 2021
* (feat) support preserveValueImports introduced in TS 4.5 This new flag keeps imports as is, essentially functioning the same as the import transformer. * Update test/transformers/typescript.test.ts Co-authored-by: Simon Holthausen <[email protected]> Co-authored-by: Christian Kaisermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new flag keeps imports as is, essentially functioning the same as the import transformer.
Before submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test