Merge branch 'main' into gh-12624

Author: Rich-Harris

.changeset/beige-lamps-ring.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: always return true from `deleteProperty` trap

.changeset/clean-shirts-yawn.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+breaking: throw error if derived creates state and then depends on it

.changeset/five-maps-reflect.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ensure assignments to state field inside constructor trigger effects

.changeset/green-baboons-sip.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ensure $inspect works with SvelteMap and SvelteSet

.changeset/green-windows-tap.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: handle deletions of previously-unread state proxy properties

.changeset/khaki-donkeys-jump.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: properly handle proxied array length mutations

.changeset/mighty-poets-fix.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: default options.filename to "(unknown)"

.changeset/olive-llamas-warn.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: properly transform destructured `$derived.by` declarations

.changeset/pre.json

@@ -21,6 +21,7 @@
     "beige-cobras-smoke",
     "beige-flies-wash",
     "beige-gifts-appear",
+    "beige-lamps-ring",
     "beige-mirrors-listen",
     "beige-rabbits-shave",
     "beige-seas-share",
@@ -82,6 +83,7 @@
     "clean-cats-wave",
     "clean-eels-beg",
     "clean-melons-wash",
+    "clean-shirts-yawn",
     "clever-chefs-relate",
     "clever-maps-travel",
     "clever-rockets-burn",
@@ -198,6 +200,7 @@
     "fifty-rice-wait",
     "fifty-steaks-float",
     "fifty-toys-invite",
+    "five-maps-reflect",
     "five-tigers-search",
     "flat-feet-visit",
     "flat-ghosts-fly",
@@ -273,12 +276,14 @@
     "great-fans-unite",
     "great-icons-retire",
     "great-plums-pretend",
+    "green-baboons-sip",
     "green-eggs-approve",
     "green-fishes-lie",
     "green-hounds-play",
     "green-snails-tickle",
     "green-tigers-judge",
     "green-walls-clap",
+    "green-windows-tap",
     "grumpy-avocados-fetch",
     "grumpy-insects-sleep",
     "grumpy-jars-sparkle",
@@ -419,6 +424,7 @@
     "mighty-files-hammer",
     "mighty-frogs-obey",
     "mighty-paws-smash",
+    "mighty-poets-fix",
     "mighty-shoes-nail",
     "modern-apricots-promise",
     "modern-fishes-double",
@@ -478,6 +484,7 @@
     "olive-cobras-wonder",
     "olive-forks-grin",
     "olive-kangaroos-brake",
+    "olive-llamas-warn",
     "olive-mice-fix",
     "olive-moons-act",
     "olive-seals-sell",
@@ -538,6 +545,7 @@
     "quiet-cobras-smile",
     "quiet-crabs-nail",
     "quiet-timers-speak",
+    "rare-ears-agree",
     "rare-insects-tell",
     "rare-mirrors-act",
     "rare-pears-whisper",
@@ -606,6 +614,7 @@
     "shiny-rats-heal",
     "shiny-shrimps-march",
     "shiny-starfishes-cross",
+    "shiny-wombats-argue",
     "short-buses-camp",
     "short-countries-rush",
     "short-starfishes-beg",
@@ -628,6 +637,7 @@
     "six-boats-shave",
     "six-chicken-kneel",
     "six-gorillas-obey",
+    "six-moons-invent",
     "six-vans-add",
     "sixty-items-crash",
     "sixty-numbers-hope",
@@ -820,7 +830,9 @@
     "weak-frogs-bow",
     "weak-terms-destroy",
     "wet-bats-exercise",
+    "wet-donkeys-fry",
     "wet-games-fly",
+    "wet-pears-buy",
     "wet-pears-remain",
     "wet-wombats-repeat",
     "wicked-bikes-matter",

.changeset/shiny-wombats-argue.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: correctly hydrate empty raw blocks

.changeset/six-moons-invent.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: make internal sources ownerless

.changeset/two-cats-approve.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: repair `href` attribute mismatches

.changeset/wet-donkeys-fry.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: join text nodes separated by comments

.changeset/wet-pears-buy.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+feat: allow non-synchronous legacy component instantiation

.prettierignore

@@ -2,12 +2,12 @@
 # see: https://github.com/sveltejs/svelte/pull/9609
 documentation/docs/05-misc/03-typescript.md
 
-# The following are all duplicated with prettierignore configs in the packages,
-# which is necessary because of https://github.com/prettier/prettier-vscode/issues/3424
 packages/**/dist/*.js
 packages/**/build/*.js
 packages/**/npm/**/*
 packages/**/config/*.js
+
+# packages/svelte
 packages/svelte/messages/**/*.md
 packages/svelte/src/compiler/errors.js
 packages/svelte/src/compiler/warnings.js
@@ -17,6 +17,7 @@ packages/svelte/src/internal/shared/errors.js
 packages/svelte/src/internal/shared/warnings.js
 packages/svelte/src/internal/server/errors.js
 packages/svelte/tests/migrate/samples/*/output.svelte
+packages/svelte/tests/**/*.svelte
 packages/svelte/tests/**/_expected*
 packages/svelte/tests/**/_actual*
 packages/svelte/tests/**/expected*
@@ -29,6 +30,7 @@ packages/svelte/compiler/index.js
 playgrounds/sandbox/input/**.svelte
 playgrounds/sandbox/output
 
+# sites/svelte.dev
 sites/svelte.dev/static/svelte-app.json
 sites/svelte.dev/scripts/svelte-app/
 sites/svelte.dev/src/routes/_components/Supporters/contributors.jpg

.vscode/launch.json

@@ -1,22 +1,6 @@
 {
 	"version": "0.2.0",
 	"configurations": [
-		{
-			"type": "chrome",
-			"request": "launch",
-			"name": "Playground: Browser",
-			"url": "http://localhost:10001"
-		},
-		{
-			"type": "node",
-			"request": "launch",
-			"runtimeArgs": ["--watch"],
-			"name": "Playground: Server",
-			"outputCapture": "std",
-			"program": "start.js",
-			"cwd": "${workspaceFolder}/playgrounds/demo",
-			"cascadeTerminateToConfigurations": ["Playground: Browser"]
-		},
 		{
 			"type": "node",
 			"request": "launch",
@@ -26,11 +10,5 @@
 				"NODE_OPTIONS": "--stack-trace-limit=10000"
 			}
 		}
-	],
-	"compounds": [
-		{
-			"name": "Playground: Full",
-			"configurations": ["Playground: Server", "Playground: Browser"]
-		}
 	]
 }

benchmarking/benchmarks/kairo/kairo_avoidable.js

@@ -3,7 +3,7 @@ import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 import { busy } from './util.js';
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let computed1 = $.derived(() => $.get(head));
 	let computed2 = $.derived(() => ($.get(computed1), 0));
 	let computed3 = $.derived(() => (busy(), $.get(computed2) + 1)); // heavy computation

benchmarking/benchmarks/kairo/kairo_broad.js

@@ -2,7 +2,7 @@ import { assert, fastest_test } from '../../utils.js';
 import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let last = head;
 	let counter = 0;
 

benchmarking/benchmarks/kairo/kairo_deep.js

@@ -5,7 +5,7 @@ let len = 50;
 const iter = 50;
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let current = head;
 	for (let i = 0; i < len; i++) {
 		let c = current;

benchmarking/benchmarks/kairo/kairo_diamond.js

@@ -4,7 +4,7 @@ import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 let width = 5;
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let current = [];
 	for (let i = 0; i < width; i++) {
 		current.push(

benchmarking/benchmarks/kairo/kairo_mux.js

@@ -2,7 +2,7 @@ import { assert, fastest_test } from '../../utils.js';
 import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 
 function setup() {
-	let heads = new Array(100).fill(null).map((_) => $.source(0));
+	let heads = new Array(100).fill(null).map((_) => $.state(0));
 	const mux = $.derived(() => {
 		return Object.fromEntries(heads.map((h) => $.get(h)).entries());
 	});

benchmarking/benchmarks/kairo/kairo_repeated.js

@@ -4,7 +4,7 @@ import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 let size = 30;
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let current = $.derived(() => {
 		let result = 0;
 		for (let i = 0; i < size; i++) {

benchmarking/benchmarks/kairo/kairo_triangle.js

@@ -11,7 +11,7 @@ function count(number) {
 }
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	let current = head;
 	let list = [];
 	for (let i = 0; i < width; i++) {

benchmarking/benchmarks/kairo/kairo_unstable.js

@@ -2,7 +2,7 @@ import { assert, fastest_test } from '../../utils.js';
 import * as $ from '../../../packages/svelte/src/internal/client/index.js';
 
 function setup() {
-	let head = $.source(0);
+	let head = $.state(0);
 	const double = $.derived(() => $.get(head) * 2);
 	const inverse = $.derived(() => -$.get(head));
 	let current = $.derived(() => {

benchmarking/benchmarks/kairo/util.js

@@ -1,7 +1,6 @@
-
 export function busy() {
-  let a = 0;
-  for (let i = 0; i < 1_00; i++) {
-    a++;
-  }
+	let a = 0;
+	for (let i = 0; i < 1_00; i++) {
+		a++;
+	}
 }

benchmarking/benchmarks/mol_bench.js

@@ -20,8 +20,8 @@ const numbers = Array.from({ length: 5 }, (_, i) => i);
 
 function setup() {
 	let res = [];
-	const A = $.source(0);
-	const B = $.source(0);
+	const A = $.state(0);
+	const B = $.state(0);
 	const C = $.derived(() => ($.get(A) % 2) + ($.get(B) % 2));
 	const D = $.derived(() => numbers.map((i) => i + ($.get(A) % 2) - ($.get(B) % 2)));
 	D.equals = function (/** @type {number[]} */ l) {

benchmarking/benchmarks/sbench.js

@@ -9,7 +9,7 @@ const COUNT = 1e5;
  */
 function create_data_signals(n, sources) {
 	for (let i = 0; i < n; i++) {
-		sources[i] = $.source(i);
+		sources[i] = $.state(i);
 	}
 	return sources;
 }

documentation/docs/03-runes/02-side-effects.md

@@ -33,6 +33,8 @@ To run _side-effects_ when the component is mounted to the DOM, and when values
 
 The function passed to `$effect` will run when the component mounts, and will re-run after any changes to the values it reads that were declared with `$state` or `$derived` (including those passed in with `$props`). Re-runs are batched (i.e. changing `color` and `size` in the same moment won't cause two separate runs), and happen after any DOM updates have been applied.
 
+You can place `$effect` anywhere, not just at the top level of a component, as long as it is called during component initialization (or while a parent effect is active). It is then tied to the lifecycle of the component (or parent effect) and will therefore destroy itself when the component unmounts (or the parent effect is destroyed).
+
 You can return a function from `$effect`, which will run immediately before the effect re-runs, and before it is destroyed ([demo](/#H4sIAAAAAAAAE42SzW6DMBCEX2Vl5RDaVCQ9JoDUY--9lUox9lKsGBvZC1GEePcaKPnpqSe86_m0M2t6ViqNnu0_e2Z4jWzP3pqGbRhdmrHwHWrCUHvbOjF2Ei-caijLTU4aCYRtDUEKK0-ccL2NDstNrbRWHoU10t8Eu-121gTVCssSBa3XEaQZ9GMrpziGj0p5OAccCgSHwmEgJZwrNNihg6MyhK7j-gii4uYb_YyGUZ5guQwzPdL7b_U4ZNSOvp9T2B3m1rB5cLx4zMkhtc7AHz7YVCVwEFzrgosTBMuNs52SKDegaPbvWnMH8AhUXaNUIY6-hHCldQhUIcyLCFlfAuHvkCKaYk8iYevGGgy2wyyJnpy9oLwG0sjdNe2yhGhJN32HsUzi2xOapNpl_bSLIYnDeeoVLZE1YI3QSpzSfo7-8J5PKbwOmdf2jC6JZyD7HxpPaMk93aHhF6utVKVCyfbkWhy-hh9Z3o_2nQIAAA==)).
 
 ```svelte

eslint.config.js

@@ -39,7 +39,8 @@ export default [
 	{
 		languageOptions: {
 			parserOptions: {
-				project: true
+				projectService: true,
+				tsconfigRootDir: import.meta.dirname
 			}
 		},
 		plugins: {
@@ -64,10 +65,14 @@ export default [
 		}
 	},
 	{
-		files: ['playgrounds/**/*'],
+		// If you get an error along the lines of "@typescript-eslint/await-thenable needs a project service configured", then that likely means
+		// that eslint rules that need to be type-aware run through a Svelte file which seems unsupported at the moment. In that case, ensure that
+		// these are excluded to run on Svelte files.
+		files: ['**/*.svelte'],
 		rules: {
-			'lube/svelte-naming-convention': 'off',
-			'no-console': 'off'
+			'@typescript-eslint/await-thenable': 'off',
+			'@typescript-eslint/prefer-promise-reject-errors': 'off',
+			'@typescript-eslint/require-await': 'off'
 		}
 	},
 	{
@@ -87,6 +92,12 @@ export default [
 			'packages/svelte/src/internal/client/warnings.js',
 			'packages/svelte/src/internal/shared/warnings.js',
 			'packages/svelte/compiler/index.js',
+			// stuff we don't want to lint
+			'benchmarking/**',
+			'coverage/**',
+			'playgrounds/sandbox/**',
+			// exclude top level config files
+			'*.config.js',
 			// documentation can contain invalid examples
 			'documentation',
 			// contains a fork of the REPL which doesn't adhere to eslint rules