Remove an undefined attribute instead of setting it to "undefined" (string)

Author: kaisermann

src/shared/dom.js

@@ -82,16 +82,16 @@ export function removeListener(node, event, handler) {
 }
 
 export function setAttribute(node, attribute, value) {
-	node.setAttribute(attribute, value);
+	if (value === undefined) removeAttribute(node, attribute);
+	else node.setAttribute(attribute, value);
 }
 
 export function setAttributes(node, attributes) {
 	for (var key in attributes) {
 		if (key in node) {
 			node[key] = attributes[key];
 		} else {
-			if (attributes[key] === undefined) removeAttribute(node, key);
-			else setAttribute(node, key, attributes[key]);
+			setAttribute(node, key, attributes[key]);
 		}
 	}
 }
@@ -238,4 +238,4 @@ export function addResizeListener(element, fn) {
 			element.removeChild(object);
 		}
 	};
-}
+}

test/runtime/samples/set-undefined-attr/_config.js

@@ -0,0 +1,5 @@
+export default {
+	'skip-ssr': true,
+
+	html: '<div></div>'
+};

test/runtime/samples/set-undefined-attr/main.html

@@ -0,0 +1,14 @@
+<div {foo} {bar}></div>
+
+<script>
+	export default {
+		data: () => ({
+			foo: 1,
+			bar: undefined
+		}),
+
+		oncreate () {
+			this.set({ foo: undefined });
+		}
+	};
+</script>