Skip to content

Commit ff0ccbc

Browse files
authored
rust: Remove unused optional PostOptions parameters from non-POST methods (#1557)
## Motivation These parameters are useless, and get ignored. ## Solution Remove.
2 parents 6ec657d + 57d12df commit ff0ccbc

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

ChangeLog.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# Changelog
22

33
## Next
4-
*
4+
* Libs/Rust: Remove unused optional `PostOptions` parameters from non-POST methods ([#1557])
5+
6+
[#1557]: https://github.com/svix/svix-webhooks/pull/1557
57

68
## Version 1.43.0
79
* Libs/Go: Add convenient construction of messages with pre-serialized payload ([#1538])

rust/src/api.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,6 @@ impl<'a> Application<'a> {
312312
&self,
313313
app_id: String,
314314
application_in: ApplicationIn,
315-
_: Option<PostOptions>,
316315
) -> Result<ApplicationOut> {
317316
application_api::v1_period_application_period_update(
318317
self.cfg,
@@ -328,7 +327,6 @@ impl<'a> Application<'a> {
328327
&self,
329328
app_id: String,
330329
application_patch: ApplicationPatch,
331-
_: Option<PostOptions>,
332330
) -> Result<ApplicationOut> {
333331
application_api::v1_period_application_period_patch(
334332
self.cfg,
@@ -427,7 +425,6 @@ impl<'a> Endpoint<'a> {
427425
app_id: String,
428426
endpoint_id: String,
429427
endpoint_update: EndpointUpdate,
430-
_: Option<PostOptions>,
431428
) -> Result<EndpointOut> {
432429
endpoint_api::v1_period_endpoint_period_update(
433430
self.cfg,
@@ -445,7 +442,6 @@ impl<'a> Endpoint<'a> {
445442
app_id: String,
446443
endpoint_id: String,
447444
endpoint_patch: EndpointPatch,
448-
_: Option<PostOptions>,
449445
) -> Result<EndpointOut> {
450446
endpoint_api::v1_period_endpoint_period_patch(
451447
self.cfg,
@@ -733,7 +729,6 @@ impl<'a> Integration<'a> {
733729
app_id: String,
734730
integ_id: String,
735731
integration_update: IntegrationUpdate,
736-
_: Option<PostOptions>,
737732
) -> Result<IntegrationOut> {
738733
integration_api::v1_period_integration_period_update(
739734
self.cfg,
@@ -843,7 +838,6 @@ impl<'a> EventType<'a> {
843838
&self,
844839
event_type_name: String,
845840
event_type_update: EventTypeUpdate,
846-
_: Option<PostOptions>,
847841
) -> Result<EventTypeOut> {
848842
event_type_api::v1_period_event_type_period_update(
849843
self.cfg,
@@ -859,7 +853,6 @@ impl<'a> EventType<'a> {
859853
&self,
860854
event_type_name: String,
861855
event_type_patch: EventTypePatch,
862-
_: Option<PostOptions>,
863856
) -> Result<EventTypeOut> {
864857
event_type_api::v1_period_event_type_period_patch(
865858
self.cfg,
@@ -1346,7 +1339,6 @@ impl<'a> OperationalWebhookEndpoint<'a> {
13461339
&self,
13471340
endpoint_id: String,
13481341
endpoint_update: OperationalWebhookEndpointUpdate,
1349-
_: Option<PostOptions>,
13501342
) -> Result<OperationalWebhookEndpointOut> {
13511343
operational_webhook_endpoint_api::update_operational_webhook_endpoint(
13521344
self.cfg,

rust/tests/kitchen_sink.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ async fn test_endpoint_crud() {
111111
])),
112112
..Default::default()
113113
},
114-
None,
115114
)
116115
.await
117116
.unwrap();

0 commit comments

Comments
 (0)