Skip to content

@BeanParam annotations should work on methods #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fehguy opened this issue Apr 28, 2014 · 3 comments
Closed

@BeanParam annotations should work on methods #543

fehguy opened this issue Apr 28, 2014 · 3 comments
Assignees
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Apr 28, 2014

the update to jersey2 support does work with @BeanParam objects, however it will only find fields. It should also treat methods correctly. Here is the offending code:

https://github.com/wordnik/swagger-core/blob/master/modules/swagger-jaxrs/src/main/scala/com/wordnik/swagger/jaxrs/JaxrsApiReader.scala#L268

@fehguy fehguy modified the milestone: v1.5.0 Sep 19, 2014
@fehguy fehguy modified the milestones: v1.5.0-M1, v1.5.0 Dec 23, 2014
@whitlockjc whitlockjc self-assigned this Jan 27, 2015
@whitlockjc
Copy link
Contributor

This seems to have been completed already but the code is in master only and not the develop_2.0 branch. The important commit was a part of pull request #547. Can you (@fehguy) confirm this? If so, fixing this is as simple as merging 0adb22e from master to develop_2.0.

@fehguy
Copy link
Contributor Author

fehguy commented Jan 27, 2015

The logic is in master but it's not complete. In addition, in master it's scala and not java so it'll need a complete redo

@whitlockjc
Copy link
Contributor

Okay, I'll get started. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants