Skip to content

Commit 4a43d10

Browse files
Rody-Kirwanshockey
authored andcommitted
Sync with master (#5370)
* improvement: OAS3 $ref friendly-name regex in model.jsx (via #5334) * improvement: relax schema description styling so Markdown can be effective (via #5340) * improvement: add `isShown` check to <ModelCollapse />'s prop `expanded` logic (via #5331) * security: CVE-2018-20834 (via #5368) * bump minimum `bundlesize` version * bump `node-sass` * bump webpack + webpack-dev-server; update lockfile * release: v3.22.2
1 parent a6125cf commit 4a43d10

11 files changed

+5552
-4390
lines changed

dist/swagger-ui-bundle.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui-bundle.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui-standalone-preset.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui-standalone-preset.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/swagger-ui.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 5528 additions & 4367 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "swagger-ui",
3-
"version": "3.22.1",
3+
"version": "3.22.2",
44
"main": "dist/swagger-ui.js",
55
"repository": "[email protected]:swagger-api/swagger-ui.git",
66
"contributors": [
@@ -96,7 +96,7 @@
9696
"babel-preset-stage-0": "^6.22.0",
9797
"babel-runtime": "^6.23.0",
9898
"body-parser": "^1.18.3",
99-
"bundlesize": "^0.17.0",
99+
"bundlesize": "^0.17.2",
100100
"chromedriver": "^2.38.3",
101101
"copy-webpack-plugin": "^4.0.1",
102102
"cors": "^2.8.4",
@@ -124,7 +124,7 @@
124124
"license-checker": "^19.0.0",
125125
"mocha": "^5.1.1",
126126
"nightwatch": "^0.9.16",
127-
"node-sass": "^4.5.0",
127+
"node-sass": "^4.12.0",
128128
"npm-run-all": "^4.1.2",
129129
"null-loader": "0.1.1",
130130
"nyc": "^11.3.0",
@@ -143,10 +143,10 @@
143143
"tachyons-sass": "^4.9.2",
144144
"uglifyjs-webpack-plugin": "^1.2.5",
145145
"url-loader": "^1.0.1",
146-
"webpack": "^3.1.0",
146+
"webpack": "^3.12.0",
147147
"webpack-bundle-size-analyzer": "^2.5.0",
148148
"webpack-cli": "^2.0.4",
149-
"webpack-dev-server": "^2.11.1",
149+
"webpack-dev-server": "^2.11.5",
150150
"worker-loader": "^1.1.1"
151151
},
152152
"config": {

src/core/components/model.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default class Model extends ImmutablePureComponent {
2323
return ref.replace(/^.*#\/definitions\//, "")
2424
}
2525
if ( ref.indexOf("#/components/schemas/") !== -1 ) {
26-
return ref.replace("#/components/schemas/", "")
26+
return ref.replace(/^.*#\/components\/schemas\//, "")
2727
}
2828
}
2929

src/core/components/models.jsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,11 @@ export default class Models extends Component {
6262

6363
const schema = Map.isMap(schemaValue) ? schemaValue : Im.Map()
6464
const rawSchema = Map.isMap(rawSchemaValue) ? rawSchemaValue : Im.Map()
65-
65+
6666
const displayName = schema.get("title") || rawSchema.get("title") || name
67+
const isShown = layoutSelectors.isShown( ["models", name], false )
6768

68-
if(layoutSelectors.isShown(["models", name], false) && (schema.size === 0 && rawSchema.size > 0)) {
69+
if( isShown && (schema.size === 0 && rawSchema.size > 0) ) {
6970
// Firing an action in a container render is not great,
7071
// but it works for now.
7172
this.props.specActions.requestResolvedSubtree([...this.getSchemaBasePath(), name])
@@ -100,7 +101,7 @@ export default class Models extends Component {
100101
displayName={displayName}
101102
modelName={name}
102103
hideSelfOnExpand={true}
103-
expanded={defaultModelsExpandDepth > 1}
104+
expanded={ defaultModelsExpandDepth > 0 && isShown }
104105
>{content}</ModelCollapse>
105106
</div>
106107
}).toArray()

src/core/components/object-model.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ export default class ObjectModel extends Component {
7979
{
8080
<table className="model"><tbody>
8181
{
82-
!description ? null : <tr style={{ color: "#666", fontStyle: "italic" }}>
83-
<td>description:</td>
82+
!description ? null : <tr style={{ color: "#666", fontWeight: "normal" }}>
83+
<td style={{ fontWeight: "bold" }}>description:</td>
8484
<td>
8585
<Markdown source={ description } />
8686
</td>

0 commit comments

Comments
 (0)