date/date-time model properties rendered as string in model/schema (v2.1.0-M2)

[zyro23]

hi,

after updating 2.1.8-M1 to 2.1.0-M2, date/date-time properties are rendered as type "string" in the model schema view with a default value of "string".

previously, with 2.1.8-M1, they were rendered as type "date-time" with a default value of the current timestamp in iso format.

my model property definition did not change ({"type":"string","format":"date-time"}).

was the behavior changed intentionally? presetting the value with a valid iso date(-time) string was the better approach imho. or am i maybe missing something else that has changed and i need to adapt to?

thanks, zyro

[ponelat]

hi @zyro23,

It seems there was a bug, but it's working in with our latest source, so you should see the expected behavior in the next release or so.

Note: latest source being ...
6f1b9b6
Built with swagger-client at....
swagger-api/swagger-js@83023ca

[webron]

@zyro23 - can you retest as mentioned by @ponelat?

[zyro23]

hmm... no luck :(

this is supposed to be fixed/working with 6f1b9b6 right? i used the dist/swagger-ui.js from that revision (which is still the current develop_2.0 HEAD as of writing this..).

looking at the code, maybe the issue is that https://github.com/swagger-api/swagger-js/blob/master/lib/types/model.js#L347 checks for type === 'date-time' but as stated, my spec json contains {"type":"string","format":"date-time"}?

thanks, zyro

[ponelat]

@zyro23, perhaps I wasn't clear enough...
The fix is in swagger-js, that's why I mentioned both SHAs.
Have a look at building from the bleeding edge....
#1220 (comment)

PS: I checked again, and the fix is there :)

[zyro23]

fix confirmed working.

just made first contact with node/npm/gulp ;) went smooth with the provided pr comment. thx guys!

[webron]

Thanks for the update, closing for now. Please reopen if needed.

[grouchal]

This seems to be happening in the current version - is this tested for the in the current tests?

[ghost]

+1