Skip to content

Multiple example rendering wrong escaped => "123" is 123 #6918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mathis-m opened this issue Feb 8, 2021 · 1 comment · Fixed by #6920
Closed

Multiple example rendering wrong escaped => "123" is 123 #6918

mathis-m opened this issue Feb 8, 2021 · 1 comment · Fixed by #6920

Comments

@mathis-m
Copy link
Contributor

mathis-m commented Feb 8, 2021

I am analyzing this currently. Looks like the internal example generator generates the correct example but within the ui components in case of multiple examples (possibly ExampleValueRetainer) the value is being wrongly stored due to back and forth Immutable.js <-> js.

Originally posted by @mathis-m in #5528 (comment)
@mathis-m mathis-m mentioned this issue Feb 9, 2021
Merged
17 tasks
@mathis-m
Copy link
Contributor Author

mathis-m commented Feb 9, 2021

This was due to that examples are not generated using sample-gen utility. Fixed this shortly by mapping the examples that are handed to the ExamplesSelectValueRetainer with the sample-gen fn.

@mathis-m mathis-m mentioned this issue Feb 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ft/value retainer sample gen mathis-m/swagger-ui
1 participant
@mathis-m