Skip to content

Commit 399c885

Browse files
authored
* Revert "Create fallback font manager to solve performance drops (flutter-tizen#78)" This reverts commit c761164. * Revert "Fix font breaking issues (flutter-tizen#69)" This reverts commit 5552dd5. * Add SamsungOneUI to DefaultFontFamilies Signed-off-by: Boram Bae <[email protected]>
1 parent 0abadae commit 399c885

File tree

6 files changed

+4
-82
lines changed

6 files changed

+4
-82
lines changed

azure-pipelines.yml

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ jobs:
7373
--target-sysroot $HOME/tizen_tools/sysroot/$(arch) \
7474
--target-triple $(targetTriple) \
7575
--runtime-mode $(mode) \
76+
--enable-fontconfig \
7677
--embedder-for-target \
7778
--disable-desktop-embeddings \
7879
--build-tizen-shell

third_party/txt/src/txt/font_collection.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ size_t FontCollection::GetFontManagersCount() const {
9999

100100
void FontCollection::SetupDefaultFontManager() {
101101
default_font_manager_ = GetDefaultFontManager();
102-
fallback_font_manager_ = GetFallbackFontManager();
103102
}
104103

105104
void FontCollection::SetDefaultFontManager(sk_sp<SkFontMgr> font_manager) {
@@ -145,8 +144,6 @@ std::vector<sk_sp<SkFontMgr>> FontCollection::GetFontManagerOrder() const {
145144
order.push_back(test_font_manager_);
146145
if (default_font_manager_)
147146
order.push_back(default_font_manager_);
148-
if (fallback_font_manager_)
149-
order.push_back(fallback_font_manager_);
150147
return order;
151148
}
152149

@@ -190,6 +187,7 @@ FontCollection::GetMinikinFontCollectionForFamilies(
190187
FindFontFamilyInManagers(family);
191188
if (minikin_family != nullptr) {
192189
minikin_families.push_back(minikin_family);
190+
break;
193191
}
194192
}
195193
}

third_party/txt/src/txt/font_collection.h

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ class FontCollection : public std::enable_shared_from_this<FontCollection> {
9191
};
9292

9393
sk_sp<SkFontMgr> default_font_manager_;
94-
sk_sp<SkFontMgr> fallback_font_manager_;
9594
sk_sp<SkFontMgr> asset_font_manager_;
9695
sk_sp<SkFontMgr> dynamic_font_manager_;
9796
sk_sp<SkFontMgr> test_font_manager_;

third_party/txt/src/txt/platform.cc

-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,4 @@ sk_sp<SkFontMgr> GetDefaultFontManager() {
1414
return SkFontMgr::RefDefault();
1515
}
1616

17-
sk_sp<SkFontMgr> GetFallbackFontManager() {
18-
return nullptr;
19-
}
20-
2117
} // namespace txt

third_party/txt/src/txt/platform.h

-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ std::vector<std::string> GetDefaultFontFamilies();
1717

1818
sk_sp<SkFontMgr> GetDefaultFontManager();
1919

20-
sk_sp<SkFontMgr> GetFallbackFontManager();
21-
2220
} // namespace txt
2321

2422
#endif // TXT_PLATFORM_H_

third_party/txt/src/txt/platform_linux.cc

+2-72
Original file line numberDiff line numberDiff line change
@@ -13,84 +13,14 @@
1313
namespace txt {
1414

1515
std::vector<std::string> GetDefaultFontFamilies() {
16-
#ifdef FLUTTER_USE_FONTCONFIG
17-
return {"TizenDefaultFont"};
18-
#else
19-
return {
20-
"SamsungOneUI",
21-
"SamsungOneUIArabic",
22-
"SamsungOneUIArmenian",
23-
"SamsungOneUIBangla",
24-
"SamsungOneUIDevanagari",
25-
"SamsungOneUIEthiopic",
26-
"SamsungOneUIFallback",
27-
"SamsungOneUIGeorgian",
28-
"SamsungOneUIGujarati",
29-
"SamsungOneUIGurmukhi",
30-
"SamsungOneUIHebrew",
31-
"SamsungOneUIJP",
32-
"SamsungOneUIKannada",
33-
"SamsungOneUIKhmer",
34-
"SamsungOneUIKorean",
35-
"SamsungOneUIKoreanH",
36-
"SamsungOneUILao",
37-
"SamsungOneUIMalayalam",
38-
"SamsungOneUIMyanmar",
39-
"SamsungOneUIOdia",
40-
"SamsungOneUIOlChiki",
41-
"SamsungOneUISCN",
42-
"SamsungOneUISinhala",
43-
"SamsungOneUITCN",
44-
"SamsungOneUITagalog",
45-
"SamsungOneUITamil",
46-
"SamsungOneUITelugu",
47-
"SamsungOneUIThai",
48-
"SamsungOneFallback",
49-
"SECEmoji",
50-
"BreezeSans",
51-
"BreezeSansArabic",
52-
"BreezeSansArmenian",
53-
"BreezeSansBengali",
54-
"BreezeSansChinese",
55-
"BreezeSansEthiopic",
56-
"BreezeSansGeorgian",
57-
"BreezeSansGujarathi",
58-
"BreezeSansHebrew",
59-
"BreezeSansHindi",
60-
"BreezeSansJapanese",
61-
"BreezeSansKannada",
62-
"BreezeSansKhmer",
63-
"BreezeSansKorean",
64-
"BreezeSansLao",
65-
"BreezeSansMalayalam",
66-
"BreezeSansMeeteiMayek",
67-
"BreezeSansMyanmar",
68-
"BreezeSansOriya",
69-
"BreezeSansPunjabi",
70-
"BreezeSansSinhala",
71-
"BreezeSansTamilBreezeSansTamil",
72-
"BreezeSansTelugu",
73-
"BreezeSansThai",
74-
"BreezeSansTibetan",
75-
"BreezeSansFallback",
76-
"BreezeColorEmoji",
77-
};
78-
#endif
16+
return {"TizenDefaultFont", "SamsungOneUI"};
7917
}
8018

8119
sk_sp<SkFontMgr> GetDefaultFontManager() {
8220
#ifdef FLUTTER_USE_FONTCONFIG
8321
return SkFontMgr::RefDefault();
8422
#else
85-
return SkFontMgr_New_Custom_Directory("/usr/share/fonts");
86-
#endif
87-
}
88-
89-
sk_sp<SkFontMgr> GetFallbackFontManager() {
90-
#ifdef FLUTTER_USE_FONTCONFIG
91-
return nullptr;
92-
#else
93-
return SkFontMgr_New_Custom_Directory("/usr/share/fallback_fonts");
23+
return SkFontMgr_New_Custom_Directory("/usr/share/fonts/");
9424
#endif
9525
}
9626

0 commit comments

Comments
 (0)