Skip to content

Commit dad9f69

Browse files
authored
Remove not used code (flutter-tizen#18)
* Remove not used code - Remove visibility change callback which is not used in text input - Remove not used parameter from RegisterIMFcallback * Extemal_texture_gl does not rely on tbm_bo.h
1 parent 167ac22 commit dad9f69

File tree

5 files changed

+3
-14
lines changed

5 files changed

+3
-14
lines changed

shell/platform/tizen/channels/text_input_channel.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ TextInputChannel::TextInputChannel(flutter::BinaryMessenger* messenger,
300300
engine_->tizen_native_window->GetWindowHandle();
301301
ecore_imf_context_client_window_set(
302302
imfContext_, (void*)ecore_wl2_window_id_get(ecoreWindow));
303-
RegisterIMFCallback(ecoreWindow);
303+
RegisterIMFCallback();
304304
} else {
305305
LoggerE("Failed to create imfContext");
306306
}
@@ -636,7 +636,7 @@ void TextInputChannel::HideSoftwareKeyboard() {
636636
}
637637
}
638638

639-
void TextInputChannel::RegisterIMFCallback(Ecore_Wl2_Window* ecoreWindow) {
639+
void TextInputChannel::RegisterIMFCallback() {
640640
// ecore_imf_context_input_panel_enabled_set(imfContext_, false);
641641
ecore_imf_context_event_callback_add(imfContext_, ECORE_IMF_CALLBACK_COMMIT,
642642
CommitCallback, this);

shell/platform/tizen/channels/text_input_channel.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class TextInputChannel {
4747
void NonIMFFallback(Ecore_Event_Key* keyDownEvent);
4848
void EnterPressed(flutter::TextInputModel* model);
4949
void SelectPressed(flutter::TextInputModel* model);
50-
void RegisterIMFCallback(Ecore_Wl2_Window* ecoreWindow);
50+
void RegisterIMFCallback();
5151
void UnregisterIMFCallback();
5252

5353
std::unique_ptr<flutter::MethodChannel<rapidjson::Document>> channel_;

shell/platform/tizen/external_texture_gl.h

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#define FLUTTER_SHELL_PLATFORM_TIZEN_EXTERNAL_TEXTURE_GL_H_
77

88
#include <stdint.h>
9-
#include <tbm_bo.h>
109
#include <tbm_bufmgr.h>
1110
#include <tbm_drm_helper.h>
1211
#include <tbm_surface.h>

shell/platform/tizen/touch_event_handler.cc

-7
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ TouchEventHandler::TouchEventHandler(TizenEmbedderEngine *engine)
2020
ecore_event_handler_add(ECORE_EVENT_MOUSE_WHEEL, OnTouch, this));
2121
touch_event_handlers_.push_back(
2222
ecore_event_handler_add(ECORE_EVENT_MOUSE_MOVE, OnTouch, this));
23-
touch_event_handlers_.push_back(ecore_event_handler_add(
24-
ECORE_WL2_EVENT_WINDOW_VISIBILITY_CHANGE, OnTouch, this));
2523
}
2624

2725
TouchEventHandler::~TouchEventHandler() {
@@ -89,11 +87,6 @@ Eina_Bool TouchEventHandler::OnTouch(void *data, int type, void *event) {
8987
self->SendFlutterPointerEvent(kMove, move_event->x, move_event->y, 0, 0,
9088
move_event->timestamp);
9189
}
92-
} else if (type == ECORE_WL2_EVENT_WINDOW_VISIBILITY_CHANGE) {
93-
auto *focus_event =
94-
reinterpret_cast<Ecore_Wl2_Event_Window_Visibility_Change *>(event);
95-
LoggerD("Visibility changed: %u, %d", focus_event->win,
96-
focus_event->fully_obscured);
9790
} else if (type == ECORE_EVENT_MOUSE_WHEEL) {
9891
auto *wheel_event = reinterpret_cast<Ecore_Event_Mouse_Wheel *>(event);
9992
double scroll_delta_x = 0.0, scroll_delta_y = 0.0;

shell/platform/tizen/touch_event_handler.h

-3
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55
#ifndef EMBEDDER_TOUCH_EVENT_HANDLER_H_
66
#define EMBEDDER_TOUCH_EVENT_HANDLER_H_
77

8-
#define EFL_BETA_API_SUPPORT
98
#include <Ecore_Input.h>
10-
#include <Ecore_Wl2.h>
11-
129
#include <vector>
1310

1411
#include "flutter/shell/platform/embedder/embedder.h"

0 commit comments

Comments
 (0)