Skip to content

Commit c9f3fc3

Browse files
committed
Refactor tizen_sdk.dart
1 parent ed6951f commit c9f3fc3

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

lib/tizen_sdk.dart

+12-8
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class TizenSdk {
2222
TizenSdk._(this.directory);
2323

2424
/// See: [AndroidSdk.locateAndroidSdk] in `android_sdk.dart`
25-
factory TizenSdk.locateSdk() {
25+
static TizenSdk locateSdk() {
2626
Directory tizenHomeDir;
2727
final Map<String, String> environment = globals.platform.environment;
2828
final File sdb = globals.os.which('sdb');
@@ -58,14 +58,18 @@ class TizenSdk {
5858
Directory get sdkDataDirectory {
5959
final File sdkInfo = directory.childFile('sdk.info');
6060
if (!sdkInfo.existsSync()) {
61-
return null;
61+
throwToolExit(
62+
'The sdk.info file could not be found. Tizen Studio is out of date or corrupted.',
63+
);
6264
}
6365
// ignore: invalid_use_of_visible_for_testing_member
6466
final Map<String, String> info = parseIniLines(sdkInfo.readAsLinesSync());
6567
if (info.containsKey('TIZEN_SDK_DATA_PATH')) {
6668
return globals.fs.directory(info['TIZEN_SDK_DATA_PATH']);
6769
}
68-
return null;
70+
throwToolExit(
71+
'The SDK data directory could not be found. Tizen Studio is out of date or corrupted.',
72+
);
6973
}
7074

7175
/// The SDK version number in the "x.y[.z]" format, or null if not found.
@@ -102,11 +106,11 @@ class TizenSdk {
102106
? 'package-manager-cli.exe'
103107
: 'package-manager-cli.bin');
104108

105-
File get securityProfilesFile =>
106-
sdkDataDirectory.childDirectory('profile').childFile('profiles.xml');
107-
108-
SecurityProfiles get securityProfiles =>
109-
SecurityProfiles.parseFromXml(securityProfilesFile);
109+
SecurityProfiles get securityProfiles {
110+
final File manifest =
111+
sdkDataDirectory.childDirectory('profile').childFile('profiles.xml');
112+
return SecurityProfiles.parseFromXml(manifest);
113+
}
110114

111115
String get defaultNativeCompiler => 'llvm-10.0';
112116

0 commit comments

Comments
 (0)