Skip to content

Commit 037b702

Browse files
committed
fix location header lookup
1 parent e2636a4 commit 037b702

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

Diff for: Sources/AsyncHTTPClient/HTTPClient+HTTPCookie.swift

+1-5
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,8 @@ extension HTTPClient {
140140
}
141141

142142
extension HTTPClient.Response {
143-
var cookieHeaders: [HTTPHeaders.Element] {
144-
return headers.filter { $0.name.lowercased() == "set-cookie" }
145-
}
146-
147143
/// List of HTTP cookies returned by the server.
148144
public var cookies: [HTTPClient.Cookie] {
149-
return self.cookieHeaders.compactMap { HTTPClient.Cookie(header: $0.value, defaultDomain: self.host) }
145+
return self.headers["set-cookie"].compactMap { HTTPClient.Cookie(header: $0, defaultDomain: self.host) }
150146
}
151147
}

Diff for: Sources/AsyncHTTPClient/HTTPHandler.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -843,11 +843,11 @@ internal struct RedirectHandler<ResponseType> {
843843
return nil
844844
}
845845

846-
guard let location = headers.first(where: { $0.name == "Location" }) else {
846+
guard let location = headers.first(name: "Location") else {
847847
return nil
848848
}
849849

850-
guard let url = URL(string: location.value, relativeTo: request.url) else {
850+
guard let url = URL(string: location, relativeTo: request.url) else {
851851
return nil
852852
}
853853

Diff for: Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ internal final class HttpBinHandler: ChannelInboundHandler {
269269
return
270270
case "/redirect/302":
271271
var headers = HTTPHeaders()
272-
headers.add(name: "Location", value: "/ok")
272+
headers.add(name: "location", value: "/ok")
273273
self.resps.append(HTTPResponseBuilder(status: .found, headers: headers))
274274
return
275275
case "/redirect/https":

0 commit comments

Comments
 (0)