Skip to content

Commit 5f16c7b

Browse files
committed
Disable warnings as errors on 6.0
Motivation: We currently have a range of thread-safety warnings on Swift 6.0 (which will be errors in Swift 6 Language mode). Resolving these is out of scope for CI work. Modifications: Disabled warnings-as-errors on Swift 6 CI pipelines Result: Resolve Swift 6 CI failures.
1 parent fcf642b commit 5f16c7b

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ jobs:
1414
linux_5_8_enabled: false
1515
linux_5_9_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
1616
linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
17-
linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
17+
linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
1818
linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
1919
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"

.github/workflows/pull_request.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
with:
1717
linux_5_9_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
1818
linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error"
19-
linux_6_0_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
19+
linux_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
2020
linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
2121
linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"
2222

.licenseignore

+2
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,5 @@ Dockerfile
3333
.dockerignore
3434
Snippets/*
3535
dev/git.commit.template
36+
.unacceptablelanguageignore
37+
Tests/AsyncHTTPClientTests/Resources/*.pem

.swift-format

+6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@
1818
"maximumBlankLines" : 1,
1919
"respectsExistingLineBreaks" : true,
2020
"prioritizeKeepingFunctionOutputTogether" : true,
21+
"noAssignmentInExpressions" : {
22+
"allowedFunctions" : [
23+
"XCTAssertNoThrow",
24+
"XCTAssertThrowsError"
25+
]
26+
},
2127
"rules" : {
2228
"AllPublicDeclarationsHaveDocumentation" : false,
2329
"AlwaysUseLiteralForEmptyCollectionInit" : false,

0 commit comments

Comments
 (0)