Skip to content

Commit 663aaae

Browse files
committed
Rebase fixes
1 parent 32be55b commit 663aaae

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTP1.1/HTTP1ClientChannelHandler.swift

+12-12
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import NIO
1717
import NIOHTTP1
1818

1919
final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
20-
typealias OutboundIn = HTTPExecutingRequest
20+
typealias OutboundIn = HTTPExecutableRequest
2121
typealias OutboundOut = HTTPClientRequestPart
2222
typealias InboundIn = HTTPClientResponsePart
2323

@@ -35,7 +35,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
3535
private var channelContext: ChannelHandlerContext?
3636

3737
/// the currently executing request
38-
private var request: HTTPExecutingRequest?
38+
private var request: HTTPExecutableRequest?
3939
private var idleReadTimeoutTimer: Scheduled<Void>?
4040

4141
let connection: HTTP1Connection
@@ -266,10 +266,10 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
266266

267267
// MARK: Private HTTPRequestExecutor
268268

269-
private func writeRequestBodyPart0(_ data: IOData, request: HTTPExecutingRequest) {
269+
private func writeRequestBodyPart0(_ data: IOData, request: HTTPExecutableRequest) {
270270
guard self.request === request, let context = self.channelContext else {
271-
// Because the HTTPExecutingRequest may run in a different thread to our eventLoop,
272-
// calls from the HTTPExecutingRequest to our ChannelHandler may arrive here after
271+
// Because the HTTPExecutableRequest may run in a different thread to our eventLoop,
272+
// calls from the HTTPExecutableRequest to our ChannelHandler may arrive here after
273273
// the request has been popped by the state machine or the ChannelHandler has been
274274
// removed from the Channel pipeline. This is a normal threading issue, noone has
275275
// screwed up.
@@ -280,7 +280,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
280280
self.run(action, context: context)
281281
}
282282

283-
private func finishRequestBodyStream0(_ request: HTTPExecutingRequest) {
283+
private func finishRequestBodyStream0(_ request: HTTPExecutableRequest) {
284284
guard self.request === request, let context = self.channelContext else {
285285
// See code comment in `writeRequestBodyPart0`
286286
return
@@ -290,7 +290,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
290290
self.run(action, context: context)
291291
}
292292

293-
private func demandResponseBodyStream0(_ request: HTTPExecutingRequest) {
293+
private func demandResponseBodyStream0(_ request: HTTPExecutableRequest) {
294294
guard self.request === request, let context = self.channelContext else {
295295
// See code comment in `writeRequestBodyPart0`
296296
return
@@ -302,7 +302,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
302302
self.run(action, context: context)
303303
}
304304

305-
private func cancelRequest0(_ request: HTTPExecutingRequest) {
305+
private func cancelRequest0(_ request: HTTPExecutableRequest) {
306306
guard self.request === request, let context = self.channelContext else {
307307
// See code comment in `writeRequestBodyPart0`
308308
return
@@ -314,7 +314,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
314314
}
315315

316316
extension HTTP1ClientChannelHandler: HTTPRequestExecutor {
317-
func writeRequestBodyPart(_ data: IOData, request: HTTPExecutingRequest) {
317+
func writeRequestBodyPart(_ data: IOData, request: HTTPExecutableRequest) {
318318
if self.eventLoop.inEventLoop {
319319
self.writeRequestBodyPart0(data, request: request)
320320
} else {
@@ -324,7 +324,7 @@ extension HTTP1ClientChannelHandler: HTTPRequestExecutor {
324324
}
325325
}
326326

327-
func finishRequestBodyStream(_ request: HTTPExecutingRequest) {
327+
func finishRequestBodyStream(_ request: HTTPExecutableRequest) {
328328
if self.eventLoop.inEventLoop {
329329
self.finishRequestBodyStream0(request)
330330
} else {
@@ -334,7 +334,7 @@ extension HTTP1ClientChannelHandler: HTTPRequestExecutor {
334334
}
335335
}
336336

337-
func demandResponseBodyStream(_ request: HTTPExecutingRequest) {
337+
func demandResponseBodyStream(_ request: HTTPExecutableRequest) {
338338
if self.eventLoop.inEventLoop {
339339
self.demandResponseBodyStream0(request)
340340
} else {
@@ -344,7 +344,7 @@ extension HTTP1ClientChannelHandler: HTTPRequestExecutor {
344344
}
345345
}
346346

347-
func cancelRequest(_ request: HTTPExecutingRequest) {
347+
func cancelRequest(_ request: HTTPExecutableRequest) {
348348
if self.eventLoop.inEventLoop {
349349
self.cancelRequest0(request)
350350
} else {

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTP1.1/HTTP1Connection.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ final class HTTP1Connection {
8686
}
8787
}
8888

89-
func execute(request: HTTPExecutingRequest) {
89+
func execute(request: HTTPExecutableRequest) {
9090
self.channel.write(request, promise: nil)
9191
}
9292

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTPExecutableRequest.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ import NIOHTTP1
120120
/// - The executor may have received an error in thread A that it passes along to the request.
121121
/// After having passed on the error, the executor considers the request done and releases
122122
/// the request's reference.
123-
/// - The request may issue a call to `writeRequestBodyPart(_: IOData, task: HTTPExecutingRequest)`
123+
/// - The request may issue a call to `writeRequestBodyPart(_: IOData, task: HTTPExecutableRequest)`
124124
/// on thread B in the same moment the request error above occurred. For this reason it may
125125
/// happen that the executor receives, the invocation of `writeRequestBodyPart` after it has
126126
/// failed the request.

0 commit comments

Comments
 (0)