Code review

Author: fabianfett

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTP1.1/HTTP1ClientChannelHandler.swift

@@ -91,10 +91,6 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
         self.run(action, context: context)
     }
 
-    func close(context: ChannelHandlerContext, mode: CloseMode, promise: EventLoopPromise<Void>?) {
-        context.close(mode: mode, promise: promise)
-    }
-
     func write(context: ChannelHandlerContext, data: NIOAny, promise: EventLoopPromise<Void>?) {
         self.logger.trace("New request to execute")
 
@@ -135,28 +131,28 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
 
     // MARK: - Run Actions
 
-    func run(_ action: HTTP1ConnectionStateMachine.Action, context: ChannelHandlerContext) {
+    private func run(_ action: HTTP1ConnectionStateMachine.Action, context: ChannelHandlerContext) {
         switch action {
         case .sendRequestHead(let head, startBody: let startBody):
             if startBody {
-                context.write(wrapOutboundOut(.head(head)), promise: nil)
+                context.write(self.wrapOutboundOut(.head(head)), promise: nil)
                 context.flush()
 
                 self.request!.requestHeadSent()
                 self.request!.resumeRequestBodyStream()
             } else {
-                context.write(wrapOutboundOut(.head(head)), promise: nil)
-                context.write(wrapOutboundOut(.end(nil)), promise: nil)
+                context.write(self.wrapOutboundOut(.head(head)), promise: nil)
+                context.write(self.wrapOutboundOut(.end(nil)), promise: nil)
                 context.flush()
 
                 self.request!.requestHeadSent()
             }
 
         case .sendBodyPart(let part):
-            context.writeAndFlush(wrapOutboundOut(.body(part)), promise: nil)
+            context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: nil)
 
         case .sendRequestEnd:
-            context.writeAndFlush(wrapOutboundOut(.end(nil)), promise: nil)
+            context.writeAndFlush(self.wrapOutboundOut(.end(nil)), promise: nil)
 
         case .pauseRequestBodyStream:
             self.request!.pauseRequestBodyStream()
@@ -293,7 +289,7 @@ final class HTTP1ClientChannelHandler: ChannelDuplexHandler {
         self.run(action, context: self.channelContext)
     }
 
-    func cancelRequest0(_ request: HTTPExecutingRequest) {
+    private func cancelRequest0(_ request: HTTPExecutingRequest) {
         guard self.request === request else {
             // very likely we got threading issues here...
             return

Diff for: Sources/AsyncHTTPClient/ConnectionPool/HTTP1.1/HTTP1Connection.swift

@@ -25,7 +25,8 @@ protocol HTTP1ConnectionDelegate {
 final class HTTP1Connection {
     let channel: Channel
 
-    /// the connection pool that created the connection
+    /// the connection's delegate, that will be informed about connection close and connection release
+    /// (ready to run next request).
     let delegate: HTTP1ConnectionDelegate
 
     enum State {